Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support FN lines with end of function line number #25120

Closed
wants to merge 1 commit into from
Closed

Support FN lines with end of function line number #25120

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 29, 2025

Fixes #25118

@fmeum fmeum requested a review from lberki as a code owner January 29, 2025 08:10
@fmeum fmeum requested a review from c-mita January 29, 2025 08:10
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 29, 2025
@iancha1992 iancha1992 added the team-Core Skyframe, bazel query, BEP, options parsing, bazelrc label Jan 29, 2025
c-mita
c-mita approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@c-mita c-mita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-mita c-mita added coverage awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 30, 2025
@copybara-service copybara-service bot closed this in c574715 Feb 3, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 3, 2025
@fmeum fmeum deleted the 25118-lcov-fn branch February 3, 2025 14:47
@fmeum
Copy link
Collaborator Author

fmeum commented Feb 3, 2025

@c-mita Could you create a new coverage tools release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-mita c-mita c-mita approved these changes

@lberki lberki Awaiting requested review from lberki lberki is a code owner

Assignees
No one assigned
Labels
coverage team-Core Skyframe, bazel query, BEP, options parsing, bazelrc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LcovParser does not follow spec for FN: line
3 participants
@fmeum @c-mita @iancha1992