[8.1.0] Add support for path mapping to CppArchive
#25146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly requires wiring up the existing machinery for structured variables and (most) link build variables. Utility methods on `PathMappers` are moved to `PathMapper` so that they can be dependend on by `AbstractCommandLine` without creating a cycle. Work towards bazelbuild#22658 (reply in thread) Work towards bazelbuild#6526 Closes bazelbuild#25081. PiperOrigin-RevId: 721499678 Change-Id: I4551f268093c7b851791a41deb57292b2c23afb7
bazel-io
added
team-Performance
comius
approved these changes
Jan 31, 2025
Merged
via the queue into
bazelbuild:release-8.1.0
with commit Jan 31, 2025
65621ac
46 checks passed
github-actions
bot
removed
the
awaiting-review
meteorcloudy
added a commit
that referenced
this pull request
Jan 31, 2025
This reverts commit 65621ac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly requires wiring up the existing machinery for structured variables and (most) link build variables.
Utility methods on
PathMappersare moved toPathMapperso that they can be dependend on byAbstractCommandLinewithout creating a cycle.Work towards #22658 (reply in thread)
Work towards #6526
Closes #25081.
PiperOrigin-RevId: 721499678
Change-Id: I4551f268093c7b851791a41deb57292b2c23afb7
Commit 7f6e649