chore: install buildifier pre-commit #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
requested review from
meteorcloudy,
jin,
Wyverald,
ahumesky and
gregestren
as code owners
alexeagle
force-pushed
the
buildifier
branch
from
cc46945
to
ce60bcf
Compare
meteorcloudy
approved these changes
Sep 25, 2023
alexeagle
added a commit
to alexeagle/rules_license
that referenced
this pull request
Oct 29, 2023
Similar to bazelbuild/examples#310 This ensures that contributors outside google3 have a means to easily make buildifier-clean commits. It is purely opt-in, and we assume that google3 users will have buildifier run for them in another way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, there's no CI enforcement that users install the pre-commit hook at this point.