-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump Bazel version #7093
base: master
Are you sure you want to change the base?
Conversation
@iancha1992 something is wrong with buildkite, could you please take a look? |
@tpasternak I retried the failing tests and we may need to check the asserts in some tests: |
applied recommendation from here: bazelbuild#7058 (comment)
1923183
to
d5bfef9
Compare
thank you @mai93 update: |
In bazel8:
in bazel7:
|
For the context - the failing test is here, and there's an explicit comment about it intellij/aspect/testing/tests/src/com/google/idea/blaze/aspect/proto/jpl/JavaProtoLibraryTest.java Lines 46 to 47 in 8581c5f
|
applied recommendation from here: #7058 (comment)
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>
Description of this change