Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Bazel version #7093

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tpasternak
Copy link
Collaborator

applied recommendation from here: #7058 (comment)

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

@github-actions github-actions bot added the awaiting-review Awaiting review from Bazel team on PRs label Dec 2, 2024
@tpasternak
Copy link
Collaborator Author

@iancha1992 something is wrong with buildkite, could you please take a look?

@mai93
Copy link
Collaborator

mai93 commented Dec 2, 2024

@tpasternak I retried the failing tests and we may need to check the asserts in some tests:
Log for intellij-plugin-aspect
Log for intellij-ue-plugin

@sgowroji sgowroji added the product: IntelliJ IntelliJ plugin label Dec 3, 2024
applied recommendation from here: bazelbuild#7058 (comment)
@tpasternak
Copy link
Collaborator Author

thank you @mai93

update:
for jpl:bar_java_proto a JavaRuleOutputJarsProvider$JavaOutput in bazel 8, but not bazel 7

@tpasternak
Copy link
Collaborator Author

In bazel8:

bazel cquery --output=starlark "--starlark:expr=providers(target)['@@rules_java+//java/private:java_info.bzl%JavaInfo'].java_outputs" //aspect/testing/tests/src/com/google/idea/blaze/aspect/proto/jpl:bar_java_proto 

[<unknown object com.google.devtools.build.lib.rules.java.JavaRuleOutputJarsProvider$JavaOutput>]

in bazel7:

bazel cquery --output=starlark "--starlark:expr=providers(target)['@@_builtins//:common/java/java_info.bzl%JavaInfo'].java_outputs" //aspect/testing/tests/src/com/google/idea/blaze/aspect/proto/jpl:bar_java_proto 

[]

@tpasternak
Copy link
Collaborator Author

For the context - the failing test is here, and there's an explicit comment about it

// We don't want java_proto_library to be rolling up any jars
assertThat(jpl.getJavaIdeInfo().getJarsList()).isEmpty();

@tpasternak
Copy link
Collaborator Author

tpasternak commented Dec 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Awaiting review from Bazel team on PRs product: IntelliJ IntelliJ plugin
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

3 participants