[AOSP-pick] [FL-22733] Notify the user about missing Android SDK or required Android platforms. #7231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following scenarios are covered with the changes: * No Android SDK is installed at all: we offer a fix to install SDK into the default location * Some platforms are missing (for example, we have SDK with platform 34, but the project requires 35): we offer to download the platform in this case * Project has an SDK in local.properties different from the one used by IDE (default or from ANDROID_HOME): in this case we rewrite local.properties and show a notification to the user One more important thing: the way we detect Android projects was altered, also in IDEA. Before the changes, we were looking for a top-level folder app with the AndroidManifest.xml, which is not always the case (especially with our wizard projects we typically have composeApp, not just app, folder). After the changes, we are looking for any folder with the specific AndroidManifest.xml path (both in main and androidMain). This will allow opening more projects in IDEA initially when no local.properties file is present. Merge-request: IJ-MR-149228 Merged-by: Ilia Bogdanovich <[email protected]> GitOrigin-RevId: 6f8e9c3bcb51e1ff2812abf1b69b73db10c09ea0 (cherry picked from commit 2dec242f247f181da7855d0b6d6713b2cd3ac523) Change-Id: I10a44780957e2f8b991e70416d0e7b24f70dbf10 AOSP: b4da8ebad9e52b2090b6116d8289888c78786b78
github-actions
bot
added
the
awaiting-review
|
aswb only, no changes for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick AOSP commit b4da8ebad9e52b2090b6116d8289888c78786b78.
The following scenarios are covered with the changes:
One more important thing: the way we detect Android projects was altered, also in IDEA.
Before the changes, we were looking for a top-level folder app with the AndroidManifest.xml, which is not always the case (especially with our wizard projects we typically have composeApp, not just app, folder).
After the changes, we are looking for any folder with the specific AndroidManifest.xml path (both in main and androidMain). This will allow opening more projects in IDEA initially when no local.properties file is present.
Merge-request: IJ-MR-149228
Merged-by: Ilia Bogdanovich [email protected]
GitOrigin-RevId: 6f8e9c3bcb51e1ff2812abf1b69b73db10c09ea0
(cherry picked from commit 2dec242f247f181da7855d0b6d6713b2cd3ac523)
Change-Id: I10a44780957e2f8b991e70416d0e7b24f70dbf10
AOSP: b4da8ebad9e52b2090b6116d8289888c78786b78