add a round robin grpc balancer #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrahs
force-pushed
the
master3
branch
2 times, most recently
from
2ffe786
to
18dd8fc
Compare
This replaces the current load balancer which was copied over from the gcp repo which uses experimental APIs from grpc-go. Depending on experimental APIs marks the SDK as experimental as well. It also complicates importing the SDK to google3 where everything must be compatbile at head. This major difference between this simple implementation and the existing one is the maximum number of streams allowed on a single connection. The existing balancer limits streams to 3 by default and allows configuring that limit. The new simpler implementation does not enforce any limit. I have tested the simple balancer by building chromium and android with and without it enabled. I observed no difference in build latency.
gkousik
approved these changes
May 1, 2024
This replaces the current load balancer which was copied over from the gcp repo which uses experimental APIs from grpc-go. Depending on experimental APIs marks the SDK as experimental as well. It also complicates importing the SDK to google3 where everything must be compatbile at head. This major difference between this simple implementation and the existing one is the maximum number of streams allowed on a single connection. The existing balancer limits streams to 3 by default and allows configuring that limit. The new simpler implementation does not enforce any limit. I have tested the simple balancer by building chromium and android with and without it enabled. I observed no difference in build latency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the current load balancer which was copied over from the gcp repo which uses experimental APIs from grpc-go.
Depending on experimental APIs marks the SDK as experimental as well. It also complicates importing the SDK to google3 where everything must be compatbile at head.
This major difference between this simple implementation and the existing one is the maximum number of streams allowed on a single connection.
The existing balancer limits streams to 3 by default and allows configuring that limit.
The new simpler implementation does not enforce any limit.
I have tested the simple balancer by building chromium and android with and without it enabled. I observed no difference in build latency.