Split the remotetool into a separate library

[gkousik]

In this CL, I'm creating an embeddedtool binary so that I can subsequently use it in reproxytool binary in re-client to implement the log file filtering functionalities. There's no behavior change associated with this CL.

Tested: Ran show_action and show_action_2 (error'ed out) on the new remotetool.

[mrahs]

It sounds like you intend to import the new package from outside the cmd dir. Last I checked, go won't let you do that. A more suitable place would be go/pkg directory.

[gkousik]

It sounds like you intend to import the new package from outside the cmd dir. Last I checked, go won't let you do that. A more suitable place would be go/pkg directory.

ah, I intend to import the new package in reclient (reproxytool), but that's also inside the cmd dir. I tried and it seems to work.

[mrahs]

It sounds like you intend to import the new package from outside the cmd dir. Last I checked, go won't let you do that. A more suitable place would be go/pkg directory.

ah, I intend to import the new package in reclient (reproxytool), but that's also inside the cmd dir. I tried and it seems to work.

Ah, it looks like there is no inherent restrictions on importing from the cmd directory. The tooling only enforces that for internal packages: go.dev/doc/go1.4#internalpackages
OTOH, it's recommended for reusable packages to be outside the cmd directory: go.dev/doc/modules/layout

For the flags, it's not recommended to let packages define their own: https://google.github.io/styleguide/go/decisions#flags

[gkousik]

Ah, it looks like there is no inherent restrictions on importing from the cmd directory. The tooling only enforces that for internal packages: go.dev/doc/go1.4#internalpackages OTOH, it's recommended for reusable packages to be outside the cmd directory: go.dev/doc/modules/layout

Moved to pkg/tool as we discussed offline and got rid of the separate embeddedtool pkg.

For the flags, it's not recommended to let packages define their own: https://google.github.io/styleguide/go/decisions#flags

Done!