Update credshelper package #571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
banikharbanda
commented
May 16, 2024
banikharbanda
commented
- Made externalTokenSource implement PerRPC creds interface as well
- Added headers and tests related to this
This adds all the credentials helper relevant code from bazelbuild/reclient/internal/pkg/auth to the new credshelper package in remote-apis-sdks with some changes: - CredentialsHelper isn't an auth "Mechanism" (since we're only supporting one mechanism, we don't need to define a type for that) - If no cache file is provided then it is assumed that no caching is required. If a valid cache file path is provided then it always caches credentials. - Updated oauth2 package version to support ReuseTokenWithExpiry - this had to be moved earlier in the Workspace file to override older versions imported from elsewhere.
- Made externalTokenSource implement PerRPC creds interface as well - Added headers and tests related to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.