Report an error on unsupported codec or invalid zstd blob #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also not sure, but probably |
ppluciennik
force-pushed
the
fix-batch-read-blobs
branch
from
edd5364
to
a5cdc86
Compare
|
Thanks for the PR. I think it's reasonable to not retry decoding errors since they come after a successful transmission. It would be great if you can add a test case. |
|
I'm sorry for a late response, but I was on vacation. I've added TestBatchDownloadBlobsBrokenCompression test to PR. |
ppluciennik
force-pushed
the
fix-batch-read-blobs
branch
from
c9646df
to
7cd94b1
Compare
|
Thank you for updating the PR. Nice work. (Sorry for the late response on my end as well..) |
mrahs
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method BatchDownloadBlobsWithStats silently ignores decoding error or unsupported codec due to lack of incrementing numErrs.