Replace uses of public fields with their associated getter methods. #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm assuming this is working towards #411. |
|
It's more like an example of the difficulty described by that issue. The fact that I need to make this PR at all is what we consider problematic. I think updating to |
|
We updated closure compiler to |
|
Done |
Yannic
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
Thanks, LGTM!
@gkdn @laurentlb @dslomov Can you review and merge?
gkdn
approved these changes
Sep 16, 2019
sgammon
pushed a commit
to Bloombox/rules_closure
that referenced
this pull request
Oct 17, 2019
ptmphuong
pushed a commit
to ptmphuong/rules_closure
that referenced
this pull request
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.