Fix windows Buildkit CI #1649
Merged
Fix windows Buildkit CI #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- windows buildkite needs batch_commands instead of shell_commands
This is needed to handle targets (with //) that are passed as args
crt-31
force-pushed
the
enablewindowsCI
branch
from
4addcac to
d0416b1
Compare
|
Hi, @crt-31, thanks for PR. You are right. Unfortunately windows support was not a priority. Thanks for taking this. |
simuons
requested changes
Nov 26, 2024
crt-31
force-pushed
the
enablewindowsCI
branch
from
d0416b1 to
3a5826b
Compare
|
@simuons, should be proper diff now. RTR. |
simuons
approved these changes
Dec 12, 2024
liucijus
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently windows CI hasn't been running for a long time (or ever?)
The issue seems to be that for windows, buildkite needs "batch_commands" instead of "shell_commands".
(Update)
Also made minor fixes to tests regarding line endings. I originally (#1529) had the system work with autocrlf=true, but this isn't handled by BazelCI. And after thinking bout it, its probably best to keep autocrlf=false, since that is what is distributed to users.. even windows users.
Motivation
Make windows CI work so we don't accidently break windows support.