Skip to content

Commit

Permalink
try appending to java_info_runtime_deps, still errors
Browse files Browse the repository at this point in the history
  • Loading branch information
ramyanaga committed Jul 17, 2024
1 parent bf68133 commit 79b881b
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions jar_jar_aspect.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,16 @@ def _jar_jar_aspect_impl(target, ctx):
# For some outputs, like those from the built in java proto aspect, the runtime output jars is empty, but the jars
# exist instead in the java_outputs section.
current_jars.extend([e.class_jar for e in target[JavaInfo].java_outputs])
java_info_runtime_deps = []

if ConfigJavaInfo in target:
print("target: ", target)
print("target[ConfigJavaInfo]")
print(target[ConfigJavaInfo])
#print([e.config_java_info for e in target[ConfigJavaInfo].config_java_info])
#current_jars.extend([e.config_java_info.runtime_output_jars for e in target[ConfigJavaInfo].config_java_info])
current_jars.extend(target[ConfigJavaInfo].config_java_info.runtime_output_jars)

#current_jars.extend(target[ConfigJavaInfo].config_java_info.runtime_output_jars)
java_info_runtime_deps.append(target[ConfigJavaInfo].config_java_info)
print("target[ConfigJavaInfo].config_java_info.runtime_output_jars")
#print(target[ConfigJavaInfo].config_java_info.runtime_output_jars)
print("current jars after if statement")
Expand All @@ -98,7 +99,9 @@ def _jar_jar_aspect_impl(target, ctx):
current_jars = [_build_nosrc_jar(ctx)]

transitive_shaded=[]
java_info_runtime_deps = []
#java_info_runtime_deps = []
print("ctx.rule: ", ctx.rule)
print("ctx.rule: ", dir(ctx.rule))
if hasattr(ctx.rule.attr, "runtime_deps"):
print("target has runtime_deps: ")
print(target)
Expand All @@ -118,6 +121,7 @@ def _jar_jar_aspect_impl(target, ctx):
transitive_shaded.append(shaded_jars.transitive_shaded)
java_info_exports.append(shaded_jars.java_info)


java_info_deps = []
for d in ctx.rule.attr.deps:
if ShadedJars in d:
Expand Down

0 comments on commit 79b881b

Please sign in to comment.