Knex migrations #20
Merged
Knex migrations #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdools
approved these changes
Jul 16, 2019
| ssh -f -L [port]:[rds name]:[port] [ssh] -N | ||
| ``` | ||
| #### Migrations | ||
| First, make sure you've installed Knex.js globally: |
There was a problem hiding this comment.
You can also run it via npx: this uses the executable in your node_modules. That's what I've been doing :)
| @@ -0,0 +1,17 @@ | |||
| const fs = require('fs'); | |||
|
|
|||
| exports.up = async (knex) => { | |||
README.md
Outdated
| @@ -34,6 +34,30 @@ npm install | |||
|
|
|||
| alternatively for production is also on [npm](https://www.npmjs.com/package/@bbc/digital-paper-edit-api) | |||
|
|
|||
| .env file should include: | |||
There was a problem hiding this comment.
I don't know if this whole block is required. Perhaps just adding the empty DB parameters in the actual .env and mentioning it in the README 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
Issue: #11
Branched from
database-spike.Describe what the PR does
State whether the PR is ready for review or whether it needs extra work
Ready for review.