Add Python server #209

tamsingreen · 2021-04-20T13:22:20Z

Is your Pull Request request related to another issue in this repository ?
bbc/digital-paper-edit-infrastructure#21

Describe what the PR does

Add a simple Python server for use on the deployed DPE EC2. Works in conjunction with this PR in the infrastructure project. It has a /status healthcheck endpoint for AWS use, and all other requests fall back to /index.html where the React app is served from.
Adds an isProduction() function to check whether Dev/Test or Prod/Live config should be used (this is added through the build process in the digital-paper-edit-infrastructure project).
Changes some const variables to letwhere reassignment was causing read-only errors when deployed

State whether the PR is ready for review or whether it needs extra work
RFR

How to test

npm run build
cd build
python server.py
Go to http://localhost:8080
Check the app name appears in the page header (this shows that env variables are working correctly - ask Tamsin or Alli for the updated config)
Log in and create a new project, update the name of a project, and add a new programme script to a project (this shows the read-only errors are fixed)

emettely

Is this already deployed?

public/server.py

tamsingreen · 2021-04-20T16:12:12Z

Is this already deployed?

No, the infra project is pulling from this branch.

emettely · 2021-04-20T17:02:40Z

Is this already deployed?

No, the infra project is pulling from this branch.

This probably should be put in the infra repository than this one. I say this because this has not very much to do with the actual Firebase / open source project, but a lot to do with the AWS / Cosmos side of things.

* Bump react-dev-utils from 11.0.3 to 11.0.4 (#193) Bumps [react-dev-utils](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-dev-utils) from 11.0.3 to 11.0.4. - [Release notes](https://github.com/facebook/create-react-app/releases) - [Changelog](https://github.com/facebook/create-react-app/blob/master/CHANGELOG-1.x.md) - [Commits](https://github.com/facebook/create-react-app/commits/HEAD/packages/react-dev-utils) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Deal with unhandled exceptions in Admin view (#204) * Deal with unhandled exceptions in Admin view. [fix] add default params to Transcripts view. Unsure when the bug was introduced. Also had to change the admin role - not sure when this was changed either. * [fix] Actually should have a better error message * [fix] Better message * refactor(env): #198 Add logic to handle both test and live envs at build Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eimi Okuno <[email protected]>

tamsingreen · 2021-04-28T09:17:31Z

Is this already deployed?

No, the infra project is pulling from this branch.

This probably should be put in the infra repository than this one. I say this because this has not very much to do with the actual Firebase / open source project, but a lot to do with the AWS / Cosmos side of things.

This is true but it's a simple, generic server with no BBC-specific config so I'm happy for it to belong in this repo.

allishultes

This looks good to me, Tamsin - hero status for your fixes with the lets / consts!

sarahrainbow · 2021-04-28T14:54:48Z

src/Util/is-production/index.js

+const isProduction = () => {
+  const parsedUrl = url.parse(window.location.href, true);
+
+  if ((parsedUrl.host) === 'digital-paper-edit.tools.bbc.co.uk') {


Could this be simplified? e.g.

return parsedUrl.host === 'digital-paper-edit.tools.bbc.co.uk'

or does this make it less clear?

sarahrainbow

Looks great and works for me! Just had one comment that may not need addressing!

aniablaziak · 2021-04-28T15:45:21Z

public/server.py

-import http.server
-import socketserver
-class MyHttpRequestHandler(http.server.SimpleHTTPRequestHandler):
+import SimpleHTTPServer, SocketServer


Does this need to use python2? Why is that?

Using python3 I had to change it back to:
import http.server, socketserver

Good q - the EC2 we use has python 2 by default (as does my Mac :) )

bevand10 · 2021-04-28T16:08:00Z

Don’t understand the need for an external dependency on url when window.location.host already provides that value? On 28 Apr 2021, at 15:55, Sarah Rainbow ***@***.***> wrote: @sarahrainbow commented on this pull request.

________________________________ In src/Util/is-production/index.js<#209 (comment)>:

@@ -0,0 +1,14 @@

+import url from 'url'; + +const isProduction = () => { + const parsedUrl = url.parse(window.location.href, true); + + if ((parsedUrl.host) === 'digital-paper-edit.tools.bbc.co.uk') { Could this be simplified? e.g. return parsedUrl.host === 'digital-paper-edit.tools.bbc.co.uk' or does this make it less clear?

tamsingreen added 2 commits April 15, 2021 15:24

Use python 2 modules

9a8048b

Return all non-status requests

d14ffab

emettely reviewed Apr 20, 2021

View reviewed changes

public/server.py Show resolved Hide resolved

allishultes and others added 5 commits April 23, 2021 11:36

fix(logs): Delete console.log

173c588

Attach config to window object for inspection

464bab8

Change const to let

bee73ad

Change other const to lets when reassigned

b224b45

tamsingreen linked an issue Apr 27, 2021 that may be closed by this pull request

Create dev (test) deployment environment on GCP #198

Closed

5 tasks

tamsingreen removed a link to an issue Apr 27, 2021

Create dev (test) deployment environment on GCP #198

Closed

5 tasks

tamsingreen linked an issue Apr 27, 2021 that may be closed by this pull request

Set up Firebase project for Cosmos deployment #218

Closed

allishultes approved these changes Apr 28, 2021

View reviewed changes

aniablaziak self-requested a review April 28, 2021 14:20

sarahrainbow reviewed Apr 28, 2021

View reviewed changes

sarahrainbow approved these changes Apr 28, 2021

View reviewed changes

aniablaziak reviewed Apr 28, 2021

View reviewed changes

tamsingreen added 2 commits April 28, 2021 18:03

Chnages from code review

6ff3028

Add files to gitignore

29ea260

tamsingreen merged commit 980dfa8 into master Apr 29, 2021

tamsingreen deleted the server branch April 29, 2021 08:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Python server #209

Add Python server #209

tamsingreen commented Apr 20, 2021 •

edited

Loading

emettely left a comment

tamsingreen commented Apr 20, 2021

emettely commented Apr 20, 2021

tamsingreen commented Apr 28, 2021

allishultes left a comment

sarahrainbow Apr 28, 2021

sarahrainbow left a comment

aniablaziak Apr 28, 2021 •

edited

Loading

tamsingreen Apr 28, 2021

bevand10 commented Apr 28, 2021 via email •

edited

Loading

Add Python server #209

Add Python server #209

Conversation

tamsingreen commented Apr 20, 2021 • edited Loading

emettely left a comment

Choose a reason for hiding this comment

tamsingreen commented Apr 20, 2021

emettely commented Apr 20, 2021

tamsingreen commented Apr 28, 2021

allishultes left a comment

Choose a reason for hiding this comment

sarahrainbow Apr 28, 2021

Choose a reason for hiding this comment

sarahrainbow left a comment

Choose a reason for hiding this comment

aniablaziak Apr 28, 2021 • edited Loading

Choose a reason for hiding this comment

tamsingreen Apr 28, 2021

Choose a reason for hiding this comment

bevand10 commented Apr 28, 2021 via email • edited Loading

tamsingreen commented Apr 20, 2021 •

edited

Loading

aniablaziak Apr 28, 2021 •

edited

Loading

bevand10 commented Apr 28, 2021 via email •

edited

Loading