Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos infra #212

Merged
merged 3 commits into from
Apr 23, 2021
Merged

Cosmos infra #212

merged 3 commits into from
Apr 23, 2021

Conversation

allishultes
Copy link
Contributor

@allishultes allishultes commented Apr 23, 2021

Is your Pull Request request related to another issue in this repository ?

See first part of comment
Related to bbc/digital-paper-edit-infrastructure#21

Because we can only deploy the live client through Cosmos by first making a deployment through test, we need a way of being able to switch which environment variables we're using based on the app's url, rather than using separate environments for test and live.

Describe what the PR does

  • Refactors so that the client decides whether to use test or live env variables based on the app's url
  • Updates Storybook version to the latest
  • Brings in changes from main branch

State whether the PR is ready for review or whether it needs extra work

Ready - to be merged into server in order to test the current Cosmos build

Additional context

dependabot bot and others added 3 commits April 19, 2021 13:39
* Deal with unhandled exceptions in Admin view.

[fix] add default params to Transcripts view. Unsure when the bug was introduced.
Also had to change the admin role - not sure when this was changed either.

* [fix] Actually should have a better error message

* [fix] Better message
@allishultes allishultes merged commit d6e401f into server Apr 23, 2021
@niklasR niklasR deleted the cosmos-infra branch May 4, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants