Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MonotoneMuseum] Resultに対応する #426

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

blhsrwznrghfzpr
Copy link
Contributor

#423
MonotoneMuseum および MonotoneMuseum:Korean の対応

  • 自動成功 -> critical
  • 自動失敗 -> fumble

備考

MonotoneMuseum:Korean のテストケースの内容が日本語版と差異があったため移植した

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #426 (2820e20) into master (2df3312) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #426   +/-   ##
=======================================
  Coverage   95.14%   95.15%           
=======================================
  Files         286      286           
  Lines       18471    18486   +15     
=======================================
+ Hits        17575    17591   +16     
+ Misses        896      895    -1     
Impacted Files Coverage Δ
lib/bcdice/game_system/MonotoneMuseum.rb 98.30% <100.00%> (+1.75%) ⬆️
...cdice/game_system/sword_world/transcendent_test.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/SwordWorld.rb 97.35% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2df3312...2820e20. Read the comment docs.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@ysakasin ysakasin merged commit 7269166 into bcdice:master Apr 21, 2021
@blhsrwznrghfzpr blhsrwznrghfzpr deleted the monotone_museum_result branch April 21, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants