Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[アマデウス] リファクタリングおよびResultの使用 #430

Merged
merged 7 commits into from
Apr 29, 2021

Conversation

blhsrwznrghfzpr
Copy link
Contributor

@blhsrwznrghfzpr blhsrwznrghfzpr commented Apr 22, 2021

#423 Amadeus, Amadeus:Korean

対象

アマデウスでの能力値判定では複数個のダイスを振り、そのうちの1つを選択して判定に用いる。
そのため、コマンドの結果にはそれぞれのダイスの成功/失敗/スペシャル/ファンブルが示されている

方針

複数個のダイスを振った場合、success/failure/critical/fumbleは次の順に判定する

  1. スペシャルがある → success かつ critical
  2. 1つ以上成功している → success
  3. 成功が無い、かつ、ファンブル → failure かつ fumble
  4. 上記以外 → failure

success/critical と failure/fumble が同時に true にならないようにしている

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #430 (d5f73b7) into master (7269166) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
+ Coverage   95.15%   95.18%   +0.02%     
==========================================
  Files         286      287       +1     
  Lines       18486    18600     +114     
==========================================
+ Hits        17591    17705     +114     
  Misses        895      895              
Impacted Files Coverage Δ
lib/bcdice/game_system/Amadeus.rb 100.00% <100.00%> (ø)
lib/bcdice/game_system.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/SkynautsBouken.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/StellarKnights.rb 98.73% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7269166...d5f73b7. Read the comment docs.

@blhsrwznrghfzpr blhsrwznrghfzpr marked this pull request as ready for review April 22, 2021 11:08
@blhsrwznrghfzpr blhsrwznrghfzpr changed the title [Amadeus] リファクタリングおよびResultの使用 [アマデウス] リファクタリングおよびResultの使用 Apr 22, 2021
@ysakasin ysakasin self-requested a review April 28, 2021 16:04
@ysakasin ysakasin merged commit 20b9e89 into bcdice:master Apr 29, 2021
@ysakasin
Copy link
Member

ありがとうございます。マージしました。

@blhsrwznrghfzpr blhsrwznrghfzpr deleted the amadeus_result branch April 29, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants