[DoubleCross] [DoubleCross:Korean] クリティカル情報を付与 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 288 288
Lines 18650 18651 +1
=======================================
+ Hits 17755 17756 +1
Misses 895 895
Continue to review full report at Codecov.
|
h-mikisato
changed the title
| @@ -117,6 +117,8 @@ def result(value_groups) | |||
| achieved_value.to_s | |||
| end | |||
|
|
|||
| r.critical = !r.fumble? && value_groups.length > 1 | |||
There was a problem hiding this comment.
クリティカルの条件は value_groups.length > 1 で十分ではないでしょうか？ クリティカル値が2以上になることが保証されているので、すべて1のファンブル時に振り足しが絶対に発生しないようになっていたと思います。
There was a problem hiding this comment.
確かに仰る通りです。こちら修正します。
ysakasin
approved these changes
Apr 28, 2021
|
ありがとうございます。マージしました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#423 対応
既にResultの対応は行われていたので、Resultにcriticalのフラグを立てる部分のみ実装しました（fumble、success、failureは実装済み）