Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRS系列のResult対応 #437

Merged
merged 5 commits into from
Apr 28, 2021
Merged

Conversation

blhsrwznrghfzpr
Copy link
Contributor

#423
SRS および SRS を継承しているシステムの Result 対応

  • SRS: スタンダードRPGシステム
  • Alshard: アルシャード
  • EtrianOdysseySRS: 世界樹の迷宮SRS
  • FullMetalPanic: フルメタル・パニック!RPG
  • MetallicGuardian: メタリックガーディアンRPG

備考
いくつかのシステムで failure のテストケースが存在しなかったため修正しました

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #437 (455811d) into master (03262c9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   95.20%   95.21%   +0.01%     
==========================================
  Files         288      288              
  Lines       18650    18689      +39     
==========================================
+ Hits        17755    17794      +39     
  Misses        895      895              
Impacted Files Coverage Δ
lib/bcdice/game_system/SRS.rb 98.23% <100.00%> (+0.08%) ⬆️
lib/bcdice/game_system/CodeLayerd.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/DoubleCross.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/LogHorizon.rb 98.72% <0.00%> (+0.01%) ⬆️
lib/bcdice/game_system/BeastBindTrinity.rb 95.90% <0.00%> (+0.36%) ⬆️
lib/bcdice/game_system/SamsaraBallad.rb 98.30% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03262c9...455811d. Read the comment docs.

@ysakasin ysakasin merged commit 669ee67 into bcdice:master Apr 28, 2021
@ysakasin
Copy link
Member

ありがとうございます。マージしました。

@blhsrwznrghfzpr blhsrwznrghfzpr deleted the srs_result branch April 28, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants