Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Satasupe] Result対応 #449

Merged
merged 4 commits into from
May 4, 2021
Merged

Conversation

h-mikisato
Copy link
Contributor

@h-mikisato h-mikisato commented Apr 30, 2021

Satasupeに対する #423 対応です。

このシステムのダイスにおいては、「目標成功度」はあくまでダイスの振り足しを止める成功度という指定で、必ずしもこれが判定の成否の閾値となる成功度とは限らず、現在は振り手にとっての成功失敗を判断する情報がないため、基本的に success , failure と断定できるもの以外は、どちらも指定しないようにしています

failure が指定されるのは「ファンブル値が6以上となった自動失敗」および「ファンブルした場合に fumble と一緒にセットされる」場合で、 success がセットされるのは「目標成功度に達した場合」です。

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #449 (5082379) into master (d5dffa9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #449   +/-   ##
=======================================
  Coverage   95.24%   95.24%           
=======================================
  Files         288      288           
  Lines       18679    18681    +2     
=======================================
+ Hits        17791    17793    +2     
  Misses        888      888           
Impacted Files Coverage Δ
lib/bcdice/game_system/Satasupe.rb 98.04% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5dffa9...5082379. Read the comment docs.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@ysakasin ysakasin merged commit 34a0329 into bcdice:master May 4, 2021
@h-mikisato h-mikisato deleted the feature/satasupe_result branch November 27, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants