Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SteamPunkers] Result対応 #457

Merged
merged 2 commits into from
May 8, 2021

Conversation

h-mikisato
Copy link
Contributor

スチームパンカーズの #423 対応です

既存コードにはクリティカルの判断がなかった(成功数の計上で一括処理していた)ため、
ルールブックの記述に基づき出目6の有無をクリティカルの判定としています。

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #457 (f6c2550) into master (6f9acf6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files         289      289           
  Lines       18748    18751    +3     
=======================================
+ Hits        17860    17863    +3     
  Misses        888      888           
Impacted Files Coverage Δ
lib/bcdice/game_system/SteamPunkers.rb 95.12% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f9acf6...f6c2550. Read the comment docs.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ysakasin ysakasin merged commit 1609f8a into bcdice:master May 8, 2021
@h-mikisato h-mikisato deleted the feature/steampunkers_result branch November 27, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants