Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GardenOrder] Result対応およびファンブル境界,連続攻撃の修正 #463

Merged
merged 4 commits into from
May 25, 2021

Conversation

yan30408
Copy link
Contributor

#423 GardenOrder: ガーデンオーダーのResult対応になります。

ついでに以下の2点に関して修正しています。

  • ファンブルとクリティカルが同時に発生した場合はファンブルが優先される (cf. p175)
  • 連続攻撃判定で最終的な成功率が50%に満たないものはエラーとして返す (cf. p217)

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #463 (c0f0c5b) into master (ff0cc55) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   95.26%   95.34%   +0.08%     
==========================================
  Files         289      290       +1     
  Lines       18760    18790      +30     
==========================================
+ Hits        17871    17916      +45     
+ Misses        889      874      -15     
Impacted Files Coverage Δ
lib/bcdice/game_system/GardenOrder.rb 100.00% <100.00%> (ø)
lib/bcdice/game_system/ScreamHighSchool.rb 100.00% <100.00%> (ø)
lib/bcdice/game_system/BlindMythos.rb 99.41% <0.00%> (-0.59%) ⬇️
lib/bcdice/game_system.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/Utakaze.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/NinjaSlayer.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/TokumeiTenkousei.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/MeikyuKingdomBasic.rb 67.88% <0.00%> (ø)
lib/bcdice/common_command/barabara_dice/result.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/StellarKnights_Korean.rb 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0cc55...c0f0c5b. Read the comment docs.

@yan30408
Copy link
Contributor Author

すみません。
ガーデンオーダーが他システムから参照されていたのが未チェックでしたので確認します💦

@yan30408
Copy link
Contributor Author

ガーデンオーターを参照していた以下の2つに関してもResult対応を行いました。

  • AceKillerGene: エースキラージーン
  • ScreamHighSchool: スクリームハイスクール

@ysakasin ysakasin merged commit 9f7434a into bcdice:master May 25, 2021
@ysakasin
Copy link
Member

@yan30408 ありがとうございます! 連続攻撃のエラーメッセージをこちらで修正してマージしました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants