Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WorldOfDarkness] Result対応( #423 ) #583

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

FredGreenfield
Copy link
Contributor

WorldOfDarknessダイスボットのResult対応( #423 )。

判定結果によって以下のステータスを返すようにした。
Revised Edition(日本語版相当)に明確にクリティカル扱いの結果はないため、criticalは返さない。

  • 成 功:success
  • 失 敗:failure
  • 大失敗:fumble

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 95.40% // Head: 95.40% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9dd3805) compared to base (354571e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #583   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         324      324           
  Lines       18295    18296    +1     
  Branches     4741     4741           
=======================================
+ Hits        17455    17456    +1     
  Misses        840      840           
Impacted Files Coverage Δ
lib/bcdice/game_system/WorldOfDarkness.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ysakasin ysakasin merged commit 288bcf6 into bcdice:master Nov 14, 2022
@FredGreenfield FredGreenfield deleted the wod_results_fix branch November 14, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants