Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBC22-972 Overlapping segments frontend #394

Merged
merged 3 commits into from
Apr 23, 2024
Merged

DBC22-972 Overlapping segments frontend #394

merged 3 commits into from
Apr 23, 2024

Conversation

fatbird
Copy link
Collaborator

@fatbird fatbird commented Apr 22, 2024

No description provided.

@fatbird fatbird requested a review from ray-oxd April 22, 2024 22:37
@ray-oxd
Copy link
Collaborator

ray-oxd commented Apr 23, 2024

  1. how is lines.json in .gitignore but still added to git?
  2. regardless, if we don't need test.js and lines.json in our repo, we should remove them from the commit

@fatbird fatbird force-pushed the features/DBC22-1962 branch from 135489f to dcd9402 Compare April 23, 2024 20:45
@ray-oxd ray-oxd force-pushed the features/DBC22-1962 branch from bbd04f1 to 16d2bcd Compare April 23, 2024 22:14
@ray-oxd ray-oxd merged commit 3731c66 into main Apr 23, 2024
3 checks passed
@ray-oxd ray-oxd deleted the features/DBC22-1962 branch April 23, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray-oxd ray-oxd ray-oxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fatbird @ray-oxd