Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRAD2-2339 #619

Merged
merged 1 commit into from
Nov 1, 2023
Merged

GRAD2-2339 #619

merged 1 commit into from
Nov 1, 2023

Conversation

arybakov-cgi
Copy link
Contributor

Monthly Graduation Run - Distribution Report Counts Error

@arybakov-cgi
GRAD2-2339
e03f46c 
Monthly Graduation Run - Distribution Report Counts Error
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Harry0589
Harry0589 reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@Harry0589 Harry0589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the file GradDataConvertionBean, on line 492 do we need to check st.getgraduationSatus != null as we are using String utils is not blank so it covers both?

@arybakov-cgi
Copy link
Contributor Author

in the file GradDataConvertionBean, on line 492 do we need to check st.getgraduationSatus != null as we are using String utils is not blank so it covers both?

The getCertificates() function call will throw NPE before reaching StringUtils, if st.getGraduationStatus() is null

@arybakov-cgi arybakov-cgi merged commit 3e7257f into grad-release Nov 1, 2023
@arybakov-cgi arybakov-cgi deleted the develop/alex-GRAD2-2339 branch February 28, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harry0589 Harry0589 Harry0589 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arybakov-cgi @Harry0589