chore: updates to credential slider (#1555)

Signed-off-by: Bryce McMath <[email protected]>
bcgov · Oct 23, 2023 · c6bcbe6 · c6bcbe6
1 parent 20012ee
commit c6bcbe6
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 7 deletions.
diff --git a/app/src/components/AddCredentialSlider.tsx b/app/src/components/AddCredentialSlider.tsx
@@ -2,7 +2,7 @@ import { AnonCredsCredentialMetadataKey } from '@aries-framework/anoncreds/build
 import { CredentialState } from '@aries-framework/core'
 import { useCredentialByState } from '@aries-framework/react-hooks'
 import { useNavigation } from '@react-navigation/native'
-import { useTheme, Screens, Stacks, testIdWithKey } from 'aries-bifold'
+import { useTheme, Screens, Stacks, testIdWithKey, testIdForAccessabilityLabel } from 'aries-bifold'
 import React, { useEffect, useState, useCallback } from 'react'
 import { useTranslation } from 'react-i18next'
 import { DeviceEventEmitter, Modal, StyleSheet, Text, TouchableOpacity, View } from 'react-native'
@@ -65,6 +65,9 @@ const AddCredentialSlider: React.FC = () => {
     drawerRowItem: {
       color: ColorPallet.grayscale.black,
     },
+    closeButton: {
+      alignSelf: 'flex-start',
+    },
   })
 
   const deactivateSlider = useCallback(() => {
@@ -113,19 +116,30 @@ const AddCredentialSlider: React.FC = () => {
             accessibilityRole={'button'}
             onPress={deactivateSlider}
             hitSlop={hitSlop}
+            style={styles.closeButton}
           >
             <Icon name="window-close" size={35} style={styles.drawerRowItem}></Icon>
           </TouchableOpacity>
-          <Text style={styles.drawerTitleText}>Choose</Text>
+          <Text style={styles.drawerTitleText}>{t('AddCredentialSlider.Choose')}</Text>
           {showGetFoundationCredential && (
-            <TouchableOpacity style={styles.drawerRow} onPress={goToPersonCredentialScreen}>
+            <TouchableOpacity
+              style={styles.drawerRow}
+              onPress={goToPersonCredentialScreen}
+              testID={testIdWithKey(testIdForAccessabilityLabel(t('BCID.GetDigitalID')))}
+              accessibilityLabel={t('BCID.GetDigitalID')}
+            >
               <Icon name="credit-card" size={30} style={styles.drawerRowItem}></Icon>
-              <Text style={{ ...styles.drawerRowItem, marginLeft: 5 }}>Get your Person credential</Text>
+              <Text style={{ ...styles.drawerRowItem, marginLeft: 5 }}>{t('BCID.GetDigitalID')}</Text>
             </TouchableOpacity>
           )}
-          <TouchableOpacity style={styles.drawerRow} onPress={goToScanScreen}>
+          <TouchableOpacity
+            style={styles.drawerRow}
+            onPress={goToScanScreen}
+            testID={testIdWithKey(testIdForAccessabilityLabel(t('AddCredentialSlider.ScanQRCode')))}
+            accessibilityLabel={t('AddCredentialSlider.ScanQRCode')}
+          >
             <Icon name="qrcode" size={30} style={styles.drawerRowItem}></Icon>
-            <Text style={{ ...styles.drawerRowItem, marginLeft: 5 }}>Scan a QR code</Text>
+            <Text style={{ ...styles.drawerRowItem, marginLeft: 5 }}>{t('AddCredentialSlider.ScanQRCode')}</Text>
           </TouchableOpacity>
         </View>
       </View>

diff --git a/app/src/localization/en/index.ts b/app/src/localization/en/index.ts
@@ -167,6 +167,10 @@ const translation = {
     "Title": "Notifications",
     "PushNotifications": "Push Notifications",
     "Continue": "Continue",
+  },
+  "AddCredentialSlider": {
+    "Choose": "Choose",
+    "ScanQRCode": "Scan a QR code",
   }
 }
 

diff --git a/app/src/localization/fr/index.ts b/app/src/localization/fr/index.ts
@@ -166,6 +166,10 @@ const translation = {
     "Title": "Notifications (FR)",
     "PushNotifications": "Push Notifications (FR)",
     "Continue": "Continue (FR)",
+  },
+  "AddCredentialSlider": {
+    "Choose": "Choose (FR)",
+    "ScanQRCode": "Scan a QR code (FR)",
   }
 }
 

diff --git a/app/src/localization/pt-br/index.ts b/app/src/localization/pt-br/index.ts
@@ -166,6 +166,10 @@ const translation = {
     "Title": "Notifications (PT-BR)",
     "PushNotifications": "Push Notifications (PT-BR)",
     "Continue": "Continue (PT-BR)",
+  },
+  "AddCredentialSlider": {
+    "Choose": "Choose (PT-BR)",
+    "ScanQRCode": "Scan a QR code (PT-BR)",
   }
 }
 

diff --git a/bifold b/bifold