Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for undefined TagSet #203

Closed
wants to merge 2 commits into from
Closed

check for undefined TagSet #203

wants to merge 2 commits into from

Conversation

TimCsaky
Copy link
Contributor

@TimCsaky TimCsaky commented Aug 31, 2023

Description

  • handle TagSet when undefined in S3 GetObjectTaggingCommand() response.
    steps to reproduce:
    mount add an empty Dell s3 bucket to coms
    upload a new file using S3 Browser/cyberduck
    call coms sync for the bucket.
    console shows error, new object not synced

  • other coms endpoints that use this command but because we add coms-id tag by default, issue did not present.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Coverage Report

Totals Coverage
Statements: 46.31% ( 2158 / 4660 )
Methods: 37.26% ( 234 / 628 )
Lines: 53.26% ( 1347 / 2529 )
Branches: 38.39% ( 577 / 1503 )

handle inconsistent response from GetObjectTaggingCommand()
@jujaga
Copy link
Member

jujaga commented Sep 2, 2023

Superceded by #204

@jujaga jujaga closed this Sep 2, 2023
@jujaga jujaga deleted the sync1 branch September 2, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants