fix: GEO-1091 fix code smells (#723)

bcgov · Sep 5, 2024 · 85044fd · 85044fd
1 parent 848bb6f
commit 85044fd
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 13 deletions.
diff --git a/admin-frontend/src/components/DashboardPage.vue b/admin-frontend/src/components/DashboardPage.vue
@@ -1,4 +1,3 @@
 <template>Dashboard placeholder</template>
 
 <script lang="ts"></script>
-<style></style>
diff --git a/admin-frontend/src/components/ReportsPage.vue b/admin-frontend/src/components/ReportsPage.vue
@@ -27,9 +27,9 @@
         <v-btn
           class="btn-primary"
           prepend-icon="mdi-export"
-          @click="exportResults()"
           :disabled="!searchResults?.length || isDownloadingCsv"
           :loading="isDownloadingCsv"
+          @click="exportResults()"
         >
           Export results (CSV)
         </v-btn>
@@ -49,10 +49,10 @@
       "
       @update:options="updateSearch"
     >
-      <template v-slot:item.update_date="{ item }">
+      <template #item.update_date="{ item }">
         {{ formatDate(item.update_date) }}
       </template>
-      <template v-slot:item.actions="{ item }">
+      <template #item.actions="{ item }">
         <v-btn
           aria-label="Open Report"
           density="compact"
@@ -93,6 +93,7 @@ import { ReportKeys } from '../types/reports';
 import ApiService from '../services/apiService';
 import ConfirmationDialog from './util/ConfirmationDialog.vue';
 import { formatDate } from '../utils/date';
+import { NotificationService } from '../services/notificationService';
 
 const reportsCurrentlyBeingDownloaded = ref({});
 const reportSearchStore = useReportSearchStore();
@@ -109,7 +110,7 @@ const confirmDialog = ref<typeof ConfirmationDialog>();
 const itemsPerPageOptions = ref([
   { value: 10, title: '10' },
   { value: 25, title: '25' },
-  { value: 50, title: '50' }
+  { value: 50, title: '50' },
 ]);
 
 const headers = ref<any>([
@@ -187,7 +188,9 @@ async function viewReportInNewTab(reportId: string) {
     window.open(objectUrl);
   } catch (e) {
     console.log(e);
-    //Todo: show a Snackbar notification describing the error
+    NotificationService.pushNotificationError(
+      'Something went wrong.  Unable to download report.',
+    );
   }
   clearReportDownloadInProgress(reportId);
 }

diff --git a/admin-frontend/src/components/TokenExpired.vue b/admin-frontend/src/components/TokenExpired.vue
@@ -2,26 +2,26 @@
   <AuthLayout>
     <template #content>
       <v-container fluid class="root">
-        <h1 class="title mb-2">Session Expired</h1>
-        <v-alert dense variant="outlined" class="alert-error mb-3">
+        <h1 class="text-h6 mb-2">Session Expired</h1>
+        <v-alert density="compact" variant="outlined" class="alert-error mb-3">
           Your session has expired.
         </v-alert>
-        <v-btn class="btn-primary" @click="clearStorageAndRedirectToLogin">Login Again</v-btn>
+        <v-btn class="btn-primary" @click="clearStorageAndRedirectToLogin"
+          >Login Again</v-btn
+        >
       </v-container>
     </template>
   </AuthLayout>
 </template>
 
-<script setup lang='ts'>
-import { storeToRefs } from 'pinia';
+<script setup lang="ts">
 import { authStore } from '../store/modules/auth';
-import { mapState } from 'pinia';
 import { AuthRoutes } from '../utils/constant';
 import { sanitizeUrl } from '@braintree/sanitize-url';
 import AuthLayout from './util/AuthLayout.vue';
 
 const authRoutesLogin = sanitizeUrl(AuthRoutes.LOGIN_AZUREIDIR);
-const { isAuthenticated } = storeToRefs(authStore);
+
 const clearStorageAndRedirectToLogin = () => {
   authStore().setJwtToken();
   window.location.href = authRoutesLogin;