Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE][INSPECT-#287] - Partially Revert Journey Details Changes, Update to Validation #288

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

davidclaveau
Copy link
Contributor

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [INSPECT-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • Partially revert the previous Journey Details changes to accommodate a new workflow. User is now only prompted to add a Closest Major City alongside a Waterbody if one of the Waterbodies added was manually entered (i.e. 'other').
  • Small change to the getJourneyDetailsCellType function to allow this workflow, no longer provides a .Divider cell at the end of the call, but shows the new .Blank cell instead. Fixes issue where two dividers were appearing on city deletion.
  • A topDivider is added to BasicCollectionViewCell, which is added to the top of Inspection Details to split between itself and Journey Details.
  • Added/updated additional validation to the new workflow to allow Waterbodies without a Closest Major City, unless that Waterbody was 'other'.

@davidclaveau davidclaveau linked an issue Feb 13, 2024 that may be closed by this pull request
3 tasks
@davidclaveau davidclaveau merged commit 30ea488 into master Feb 13, 2024
1 check passed
@davidclaveau davidclaveau deleted the inspect-287-revert-some-journey-details branch February 13, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert Waterbody and Major City changes
2 participants