Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INSPECT-335][FEATURE] - Overnight Shift Calendar Increment #349

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

PaulGarewal
Copy link
Contributor

@PaulGarewal PaulGarewal commented Jan 17, 2025

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [INSPECT-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • Created logic to handle overnight shifts, when a shiftEnd time is before the shift start, automatically assert that the shift is overnight
  • Confirmation message will pop up to allow user to confirm it is in fact an overnight shift
  • If overnight, shiftEnd time will have a date of the next calendar day.

@PaulGarewal PaulGarewal requested a review from a team January 17, 2025 18:57
@PaulGarewal PaulGarewal self-assigned this Jan 17, 2025
This was linked to issues Jan 20, 2025
Copy link

@dallascrichmond dallascrichmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do whatever you want

@PaulGarewal PaulGarewal merged commit ffb0f29 into master Jan 20, 2025
4 checks passed
@PaulGarewal PaulGarewal deleted the 335-midnight-shift-bug branch January 20, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random timezone when Inspection submitted Midnight Shift Bug
2 participants