Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JASPER 268: Fix Criminal-document download functionality #145

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JTraill
Copy link

@JTraill JTraill commented Jan 20, 2025

Pull Request for JIRA Ticket: ----268----

1️⃣ Use our own base64url logic utilizing btoa 0️⃣

The package we currently rely on to base64 our urls has issues regarding latest JS frameworks.
This PR forgoes that package and uses our own base64url functionality.

We should at some point completely deprecate this package from the project and use the method I introduced here.

fix: criminal document download functionality
refactor: remove unneeded error handling from courtfilesearch
refactor: prettify shared.ts
build: remove if exists flag from unit-tests in FE build

Fixes # 268

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested locally with ./manage debug and ./manage start

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Documentation References

base64url package -https://github.com/brianloveswords/base64url

@JTraill JTraill marked this pull request as ready for review January 20, 2025 21:33
@JTraill JTraill self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants