JASPER 268: Fix Criminal-document download functionality #145
+64
−64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for JIRA Ticket: ----268----
1️⃣ Use our own base64url logic utilizing
btoa
0️⃣The package we currently rely on to base64 our urls has issues regarding latest JS frameworks.
This PR forgoes that package and uses our own base64url functionality.
We should at some point completely deprecate this package from the project and use the method I introduced here.
fix: criminal document download functionality
refactor: remove unneeded error handling from courtfilesearch
refactor: prettify shared.ts
build: remove if exists flag from unit-tests in FE build
Fixes # 268
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
./manage debug
and./manage start
Checklist:
Documentation References
base64url package -https://github.com/brianloveswords/base64url