forked from bcgov/supreme-court-viewer
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor initial infra code to support DEV instance resources #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Minor refactoring for naming convention and code formatting
- Added tags
- changed task def to use web - added variables for web and api images
- Renamed web task definition
- Enabled public ip
- Ensure ECS is accessed from LB only
- Adjusted ecs resources - Renamed stuff
- Added backend tfvars
- Added initial documentation
…riable from Github.
… vpc in any AWS env.
… on any environment
- Renamed cloudwatch ecs web log group
…by BC Gov AWS Instance
…by BC Gov AWS Instance
WadeBarnes
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deferring to @amlanc1 for final review and approval.
amlanc1
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for JIRA Ticket: JASPER-44
Issue ticket number and link
JASPER-44 (https://jag.gov.bc.ca/jira/browse/JASPER-44)
Description
BC Gov's AWS instance includes provisioned resources (e.g. VPC, Subnets) and the initial code had to be adjusted in order for it to work. The initial code is based from Quartech's AWS Sandbox which has a different provisioned resources.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: