Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor initial infra code to support DEV instance resources #6

Merged
merged 53 commits into from
Aug 9, 2024

Conversation

ronaldo-macapobre
Copy link

Pull Request for JIRA Ticket: JASPER-44

Issue ticket number and link

JASPER-44 (https://jag.gov.bc.ca/jira/browse/JASPER-44)

Description

BC Gov's AWS instance includes provisioned resources (e.g. VPC, Subnets) and the initial code had to be adjusted in order for it to work. The initial code is based from Quartech's AWS Sandbox which has a different provisioned resources.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Trigger the AWS Infra to DEV pipeline and succeeded.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas

Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring to @amlanc1 for final review and approval.

Copy link

@amlanc1 amlanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronaldo-macapobre ronaldo-macapobre merged commit 1b8f3c9 into master Aug 9, 2024
2 checks passed
@ronaldo-macapobre ronaldo-macapobre deleted the feature-infraPipeline branch August 13, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants