wfprev-143 Edit project: UI #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yzlucas
commented
Dec 10, 2024
yzlucas
commented
...rc/main/angular/src/app/components/edit-project/project-details/project-details.component.ts
Outdated
Show resolved
Hide resolved
agordon-vivid
requested changes
Dec 10, 2024
ssylver93
reviewed
Dec 10, 2024
| loadChildren: () => | ||
| import('src/app/components/edit-project.module').then(m => m.EditProjectModule), | ||
| }, | ||
| { path: '', redirectTo: ResourcesRoutes.MAP, pathMatch: 'full' }, // Default route to map |
There was a problem hiding this comment.
Please add the authentication check canActivate: [PrevAuthGuard] like the list and map pages above
ssylver93
reviewed
Dec 10, 2024
| </select> | ||
| </div> | ||
|
|
||
| <!-- <div class="form-item full-width"> |
There was a problem hiding this comment.
Remove this commented code?
ssylver93
reviewed
Dec 10, 2024
| fireCentreOrgUnitId: 3001, | ||
| bcParksRegionOrgUnitId: 4001, | ||
| bcParksSectionOrgUnitId: 5001, | ||
| coordinats:[48.407326,-123.329773], |
There was a problem hiding this comment.
Typo here, should be coordinates
ssylver93
reviewed
Dec 10, 2024
...ar/src/main/angular/src/app/components/list-panel/projects-list/projects-list.component.html
Outdated
Show resolved
Hide resolved
ssylver93
requested changes
Dec 10, 2024
agordon-vivid
previously approved these changes
Dec 10, 2024
updated. |
ssylver93
reviewed
Dec 10, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.