Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Major refactor to the Authorizations List and Details pages #188

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

ccallendar
Copy link
Contributor

@ccallendar ccallendar commented Jul 23, 2024

Description

Major refactoring to the Authorizations List and Details pages including:

  • Moving to the new /src/pages folder
  • Breaking into small reusable (easily testable) components
  • Add new Application Status section on details page
  • Add new empty Documents section on details page
  • Make reusable components for Search By radio buttons, Filter By checkboxes, and Search Input control.
  • Added Export to CSV button to list page

Fixes #111 #110 #170 #171

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit tests
  • End to end tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

…match the latest wording and styles from Figma
frontend/src/App.tsx Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 24, 2024

Quality Gate Passed Quality Gate passed for 'nr-omrr-transparency-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mishraomp mishraomp merged commit 92420c8 into main Jul 24, 2024
18 checks passed
@mishraomp mishraomp deleted the feat/authorizations-list-details branch July 24, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to Test / Review
Development

Successfully merging this pull request may close these issues.

Download a file of search results from text search page
2 participants