Skip to content

Commit

Permalink
FSADT1-1000: Move Add Contact button at the bottom when clicking it (#…
Browse files Browse the repository at this point in the history
…618)

* feat:
- Changed requested on FSADT1-1000
- Updated Cypress

* Fixed style for medium screens
  • Loading branch information
mamartinezmejia authored Nov 17, 2023
1 parent 398abe0 commit 030ea47
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 16 deletions.
6 changes: 4 additions & 2 deletions frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"@vue/eslint-config-typescript": "^12.0.0",
"@vue/test-utils": "^2.4.0",
"@vue/tsconfig": "^0.4.0",
"cypress": "^13.3.2",
"cypress": "^13.5.1",
"eslint": "^8.48.0",
"eslint-config-prettier": "^9.0.0",
"eslint-config-standard": "^17.1.0",
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/assets/styles/global.scss
Original file line number Diff line number Diff line change
Expand Up @@ -1479,7 +1479,7 @@ cds-header-panel[expanded] {
/* Large (from 1056px to 1311px) */
@media screen and (min-width: 1056px) and (max-width: 1311px) {
.screen {
padding: 0rem 2rem 2rem;
padding: 1rem 2rem 2rem;
align-items: center;
}

Expand Down
26 changes: 14 additions & 12 deletions frontend/src/pages/FormBCSCPage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -93,25 +93,15 @@
@error="validation.phoneNumber = !$event"
/>
</div>

<p class="body-compact-01">
You can add contacts to the account. For example, a person you want to give or receive information on your behalf.
</p>

<cds-button
kind="tertiary"
@click.prevent="addContact"
v-if="formData.location.contacts.length < 5">
<span>Add another contact</span>
<Add16 slot="icon" />
</cds-button>

<div class="frame-01" v-if="otherContacts.length > 0">
<div v-for="(contact, index) in otherContacts">
<hr />

<div class="grouping-09" :data-scroll="`additional-contact-${index + 1}`">
<span class="heading-03">Additional contact</span>
</div>

<contact-group-component
:key="index + 1"
:id="index + 1"
Expand All @@ -129,6 +119,18 @@
</div>
</div>

<p class="body-compact-01">
You can add contacts to the account. For example, a person you want to give or receive information on your behalf.
</p>

<cds-button
kind="tertiary"
@click.prevent="addContact"
v-if="formData.location.contacts.length < 5">
<span>Add another contact</span>
<Add16 slot="icon" />
</cds-button>

<hr class="divider" />

<cds-button
Expand Down

0 comments on commit 030ea47

Please sign in to comment.