Made code reviews

bcgov · Dec 3, 2024 · 405a84b · 405a84b
1 parent 4b6f62c
commit 405a84b
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 55 deletions.
diff --git a/backend/src/main/java/ca/bc/gov/app/controller/client/ClientController.java b/backend/src/main/java/ca/bc/gov/app/controller/client/ClientController.java
@@ -87,35 +87,27 @@ public Flux<ClientListDto> fullSearch(
       @RequestParam(required = false, defaultValue = "10") int size,
       @RequestParam(required = false, defaultValue = "") String keyword,
       ServerHttpResponse serverResponse) {
-
-    log.info("Listing clients: page={}, size={}, keyword={}", page, size, keyword);
-
-    return clientLegacyService
-        .search(
-            page,
-            size,
-            keyword
-        )
-        .doOnNext(pair -> {
-          Long count = pair.getSecond();
 
-          serverResponse
-            .getHeaders()
-            .putIfAbsent(
-                ApplicationConstant.X_TOTAL_COUNT, 
-                List.of(count.toString())
-            );
-          }
-        )
-        .map(Pair::getFirst)
-        .doFinally(signalType -> 
-          serverResponse
-            .getHeaders()
-            .putIfAbsent(
-                ApplicationConstant.X_TOTAL_COUNT,
-                List.of("0")
-            )
-        );
+      log.info("Listing clients: page={}, size={}, keyword={}", page, size, keyword);
+
+      return clientLegacyService
+              .search(page, size, keyword)
+              .doOnNext(pair -> {
+                  Long count = pair.getSecond();
+
+                  serverResponse
+                          .getHeaders()
+                          .putIfAbsent(
+                                  ApplicationConstant.X_TOTAL_COUNT,
+                                  List.of(count.toString()));
+              })
+              .map(Pair::getFirst)
+              .doFinally(signalType -> 
+                  serverResponse
+                          .getHeaders()
+                          .putIfAbsent(
+                                  ApplicationConstant.X_TOTAL_COUNT,
+                                  List.of("0")));
   }
 
   /**

diff --git a/legacy/src/main/java/ca/bc/gov/app/dto/ForestClientDetailsDto.java b/legacy/src/main/java/ca/bc/gov/app/dto/ForestClientDetailsDto.java
@@ -3,31 +3,29 @@
 import java.time.LocalDate;
 import java.util.List;
 
-public record ForestClientDetailsDto (
-  String clientNumber,
-  String clientName,
-  String legalFirstName,
-  String legalMiddleName,
-  String clientStatusCode,
-  String clientStatusDesc,
-  String clientTypeCode,
-  String clientTypeDesc,
-  String clientIdTypeCode,
-  String clientIdTypeDesc,
-  String clientIdentification,
-  String registryCompanyTypeCode,
-  String corpRegnNmbr,
-  String clientAcronym,
-  String wcbFirmNumber,
-  String clientComment,
-  LocalDate clientCommentUpdateDate,
-  String clientCommentUpdateUser,
-  String goodStandingInd,
-  LocalDate birthdate,
-
-  List<ForestClientLocationDto> addresses,
-  List<ForestClientContactDto> contacts,
-  List<ClientDoingBusinessAsDto> doingBusinessAs
-) {
-
+public record ForestClientDetailsDto(
+    String clientNumber,
+    String clientName, 
+    String legalFirstName,
+    String legalMiddleName, 
+    String clientStatusCode, 
+    String clientStatusDesc, 
+    String clientTypeCode,
+    String clientTypeDesc, 
+    String clientIdTypeCode, 
+    String clientIdTypeDesc,
+    String clientIdentification, 
+    String registryCompanyTypeCode, 
+    String corpRegnNmbr,
+    String clientAcronym, 
+    String wcbFirmNumber, 
+    String clientComment,
+    LocalDate clientCommentUpdateDate, 
+    String clientCommentUpdateUser, 
+    String goodStandingInd,
+    LocalDate birthdate,
+
+    List<ForestClientLocationDto> addresses, 
+    List<ForestClientContactDto> contacts,
+    List<ClientDoingBusinessAsDto> doingBusinessAs) {
 }