chore(fe): removed feature flag related to the search (#1304)

* chore(fe): removed feature flag related to the search * test: fix VITE_GREEN_DOMAIN --------- Co-authored-by: Fernando Terra <[email protected]>
bcgov · Nov 7, 2024 · 7ba1894 · 7ba1894
1 parent 7219db5
commit 7ba1894
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 8 deletions.
diff --git a/frontend/openshift.configmap.dev.yml b/frontend/openshift.configmap.dev.yml
@@ -22,4 +22,4 @@ objects:
       name: ${NAME}-${ZONE}-${COMPONENT}-config
     data:
       params.js: |
-        window.localStorage.setItem('VITE_FEATURE_FLAGS','{"STAFF_SEARCH":true}');
+        window.localStorage.setItem('VITE_FEATURE_FLAGS','{}');
diff --git a/frontend/openshift.configmap.test.yml b/frontend/openshift.configmap.test.yml
@@ -22,4 +22,4 @@ objects:
       name: ${NAME}-${ZONE}-${COMPONENT}-config
     data:
       params.js: |
-        window.localStorage.setItem('VITE_FEATURE_FLAGS','{"STAFF_SEARCH":true}');
+        window.localStorage.setItem('VITE_FEATURE_FLAGS','{}');
diff --git a/frontend/package.json b/frontend/package.json
@@ -24,7 +24,7 @@
   "scripts": {
     "start": "vite --host --port 3000",
     "build": "vue-tsc --noEmit && vite build",
-    "preview": "cross-env VITE_NODE_ENV=test VITE_GREEN_DOMAIN=green-domain.com VITE_FEATURE_FLAGS={\\\"STAFF_SEARCH\\\":true} start-server-and-test stub http://127.0.0.1:8080 start",
+    "preview": "cross-env VITE_NODE_ENV=test VITE_GREEN_DOMAIN=green-domain.com start-server-and-test stub http://127.0.0.1:8080 start",
     "preview:app": "cross-env VITE_NODE_ENV=test vite --host --port 3000",
     "typecheck": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false",
     "lint": "eslint . --fix --ignore-path .gitignore",
@@ -36,12 +36,12 @@
     "posttest:component": "mv reports/.nyc_report reports/component",
     "test:unit": "cross-env VITE_NODE_ENV=test NODE_ENV=test vitest run --coverage",
     "posttest:unit": "mv reports/.vite_report reports/unit",
-    "test:e2e": "cross-env VITE_NODE_ENV=test VITE_GREEN_DOMAIN=green-domain.com VITE_FEATURE_FLAGS={\\\"STAFF_SEARCH\\\":true} start-server-and-test preview http://127.0.0.1:3000 'cypress run --headless'",
+    "test:e2e": "cross-env VITE_NODE_ENV=test VITE_GREEN_DOMAIN=green-domain.com start-server-and-test preview http://127.0.0.1:3000 'cypress run --headless'",
     "posttest:e2e": "mv reports/.nyc_report reports/e2e",
     "pretest:report:merge": "rm -rf reports-merge && mkdir -p reports-merge && for name in component e2e unit; do cp reports/$name/coverage-final.json reports-merge/$name.json; done",
     "test:report:merge": "mkdir -p .nyc_output && rm -rf coverage && nyc --config nyc.config.json merge reports-merge &&  mv coverage.json .nyc_output/out.json && nyc --config nyc.config.json report --reporter lcov --reporter text-summary --report-dir coverage --temp-dir .nyc_output",
     "test:report:clean": "rm -rf reports && mkdir -p reports/.nyc_output/processinfo && mkdir -p coverage",
-    "test:build": "cross-env VITE_MODE=test VITE_NODE_ENV=test VITE_GREEN_DOMAIN=green-domain.com VITE_FEATURE_FLAGS={\\\"STAFF_SEARCH\\\":true} start-server-and-test preview http://127.0.0.1:3000 'cypress open'",
+    "test:build": "cross-env VITE_MODE=test VITE_NODE_ENV=test VITE_GREEN_DOMAIN=green-domain.com start-server-and-test preview http://127.0.0.1:3000 'cypress open'",
     "test:flush": "rm -rf reports && rm -rf .nyc_output && rm -rf coverage && rm -rf reports-merge",
     "posttest:flush": "npm run coverage",
     "test:unit:devtools": "cross-env VITE_NODE_ENV=test NODE_ENV=test vitest run --inspect-brk --pool threads --poolOptions.threads.singleThread"

diff --git a/frontend/src/components/MainHeaderComponent.vue b/frontend/src/components/MainHeaderComponent.vue
@@ -252,8 +252,7 @@ const handleLogoutClick = (event) => {
       <cds-side-nav-link 
         :active="$route.name == 'search'" 
         href="/search" 
-        large  
-        v-if="featureFlags.STAFF_SEARCH"
+        large 
         id="menu-list-search">
         <span>Client search</span>
         <Search16 slot="title-icon" />

diff --git a/frontend/src/routes.ts b/frontend/src/routes.ts
@@ -200,7 +200,6 @@ export const routes = [
       style: "content-stretched",
       headersStyle: "headers-compact",
       sideMenu: true,
-      featureFlagged: "STAFF_SEARCH",
       profile: true,
     },
   },