refactor: improve variable names

bcgov · Mar 11, 2024 · 98fc055 · 98fc055
1 parent 595836b
commit 98fc055
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/frontend/src/components/forms/DateInputComponent/DateInputPart.vue b/frontend/src/components/forms/DateInputComponent/DateInputPart.vue
@@ -44,14 +44,14 @@ const mask = "#".repeat(placeholder.length);
 
 const ariaLabel = `${props.parentTitle} ${datePartName}`;
 
-const cdsTextInput = ref<InstanceType<typeof CDSTextInput> | null>(null);
+const cdsTextInputRef = ref<InstanceType<typeof CDSTextInput> | null>(null);
 
-watch(cdsTextInput, async (value) => {
-  if (value) {
+watch(cdsTextInputRef, async (cdsTextInput) => {
+  if (cdsTextInput) {
     // wait for the DOM updates to complete
     await nextTick();
 
-    const input = value.shadowRoot?.querySelector("input");
+    const input = cdsTextInput.shadowRoot?.querySelector("input");
     if (input) {
       // display numeric keyboard on mobile devices
       input.inputMode = "numeric";
@@ -64,7 +64,7 @@ watch(cdsTextInput, async (value) => {
   <div class="input-group">
     <cds-text-input
       v-if="enabled"
-      ref="cdsTextInput"
+      ref="cdsTextInputRef"
       :id="id"
       :required="required"
       :label="capitalizedDatePart"

diff --git a/frontend/src/components/forms/TextInputComponent.vue b/frontend/src/components/forms/TextInputComponent.vue
@@ -123,14 +123,14 @@ const selectValue = (event: any) => {
   isUserEvent.value = true
 };
 
-const cdsTextInput = ref<InstanceType<typeof CDSTextInput> | null>(null);
+const cdsTextInputRef = ref<InstanceType<typeof CDSTextInput> | null>(null);
 
-watch([cdsTextInput, () => props.numeric], async ([cdsTextInputValue]) => {
-  if (cdsTextInputValue) {
+watch([cdsTextInputRef, () => props.numeric], async ([cdsTextInput]) => {
+  if (cdsTextInput) {
     // wait for the DOM updates to complete
     await nextTick();
 
-    const input = cdsTextInputValue.shadowRoot?.querySelector("input");
+    const input = cdsTextInput.shadowRoot?.querySelector("input");
     if (input) {
       // display either a numeric or an alphanumeric (default) keyboard on mobile devices
       input.inputMode = props.numeric ? "numeric" : "text";
@@ -144,7 +144,7 @@ watch([cdsTextInput, () => props.numeric], async ([cdsTextInputValue]) => {
     <div class="input-group">
       <cds-text-input
         v-if="enabled"
-        ref="cdsTextInput"
+        ref="cdsTextInputRef"
         :id="id"
         :required="required"
         :label="label"