SonaCloud fixes

backend/src/main/java/ca/bc/gov/app/controller/client/ClientController.java

@@ -117,23 +117,23 @@ public Flux<ClientListDto> fullSearch(
     return clientLegacyService
         .search(page, size, keyword)
         .doOnNext(pair -> {
-            Long count = pair.getSecond();
+          Long count = pair.getSecond();
 
-            serverResponse
-                .getHeaders()
-                .putIfAbsent(
-                    ApplicationConstant.X_TOTAL_COUNT,
-                    List.of(count.toString())
-                );
+          serverResponse
+            .getHeaders()
+            .putIfAbsent(
+                ApplicationConstant.X_TOTAL_COUNT,
+                List.of(count.toString())
+            );
         })
         .map(Pair::getFirst)
         .doFinally(signalType ->
-            serverResponse
-                .getHeaders()
-                .putIfAbsent(
-                    ApplicationConstant.X_TOTAL_COUNT,
-                    List.of("0")
-                )
+          serverResponse
+            .getHeaders()
+            .putIfAbsent(
+                ApplicationConstant.X_TOTAL_COUNT,
+                List.of("0")
+            )
         );
   }
 
@@ -154,12 +154,12 @@ public Flux<ClientLookUpDto> findByClientName(@PathVariable String name) {
   /**
    * Finds a client based on their registration number.
    *
-   * This endpoint retrieves client information by searching for a registration number. 
+   * <p>This endpoint retrieves client information by searching for a registration number. 
    * If no client is found, an error is returned.
    *
    * @param registrationNumber the registration number of the client to look up
    * @return a {@link Mono} emitting the {@link ClientLookUpDto} if found, or an error 
-   * if no data exists
+   *         if no data exists
    */
   @GetMapping(value = "/incorporation/{registrationNumber}")
   public Mono<ClientLookUpDto> findByRegistrationNumber(
@@ -175,7 +175,7 @@ public Mono<ClientLookUpDto> findByRegistrationNumber(
   /**
    * Searches for an individual client by user ID and last name.
    *
-   * This endpoint fetches an individual client using their user ID and last name. 
+   * <p>This endpoint fetches an individual client using their user ID and last name. 
    * The request is validated against existing records in the system.
    *
    * @param userId the unique identifier of the individual to search for

backend/src/main/java/ca/bc/gov/app/service/client/ClientLegacyService.java

@@ -22,15 +22,15 @@
 import reactor.core.publisher.Mono;
 
 /**
- * This class is responsible for interacting with the legacy API to fetch client data. It uses the
- * WebClient to send HTTP requests to the legacy API and converts the responses into Flux of
- * ForestClientDto objects. It provides several methods to search for clients in the legacy system
- * using different search criteria.
- * <p>
- * It is annotated with @Slf4j for logging, @Service to indicate that it's a Spring service bean,
- * and @Observed for metrics.
- * <p>
- * Each method logs the search parameters and the results for debugging purposes.
+ * This class is responsible for interacting with the legacy API to fetch client data. 
+ * It uses the WebClient to send HTTP requests to the legacy API and converts the responses 
+ * into Flux of ForestClientDto objects. It provides several methods to search for clients 
+ * in the legacy system using different search criteria.
+ * 
+ * <p>It is annotated with @Slf4j for logging, @Service to indicate that it's a 
+ * Spring service bean, and @Observed for metrics.
+ * 
+ * <p>Each method logs the search parameters and the results for debugging purposes.
  */
 @Slf4j
 @Service

backend/src/test/java/ca/bc/gov/app/service/client/ClientDistrictServiceIntegrationTest.java

@@ -10,7 +10,7 @@
 
 @Slf4j
 @DisplayName("Integrated Test | FSA Client District Service")
-public class ClientDistrictServiceIntegrationTest extends AbstractTestContainerIntegrationTest {
+class ClientDistrictServiceIntegrationTest extends AbstractTestContainerIntegrationTest {
 
   @Autowired
   private ClientDistrictService service;

backend/src/test/java/ca/bc/gov/app/service/client/ClientServiceIntegrationTest.java

@@ -25,7 +25,7 @@
 import reactor.test.StepVerifier;
 
 @DisplayName("Integrated Test | Client Service")
-public class ClientServiceIntegrationTest extends AbstractTestContainerIntegrationTest {
+class ClientServiceIntegrationTest extends AbstractTestContainerIntegrationTest {
 
   @Autowired
   private ClientService service;