fix(fe: FSADT1-1495): Add notification to all BC Registries cards in …

…step 1 (#1171) fix: show the Read-only notification always
bcgov · Sep 24, 2024 · d4dd307 · d4dd307
1 parent 9b7be0e
commit d4dd307
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/frontend/cypress/e2e/pages/staffform/BcRegisteredClientInformationWizardStep.cy.ts b/frontend/cypress/e2e/pages/staffform/BcRegisteredClientInformationWizardStep.cy.ts
@@ -445,21 +445,21 @@ describe("BC Registered Staff Wizard Step", () => {
         }
 
         if (scenario.showData) {
-          const success = Object.entries(scenario)
-            .filter(
-              ([key, value]) =>
-                key.startsWith("show") && key.endsWith("Notification")
-            )
-            .map(([key, value]) => value)
-            .every((value) => value === false);
+          /*
+          This variable might be useful in the future to test the button Next gets enabled on
+          success. But we'll probably need to fix FSADT1-1496 first.
+          */
+          // const success = Object.entries(scenario)
+          //   .filter(
+          //     ([key, value]) =>
+          //       key.startsWith("show") && key.endsWith("Notification")
+          //   )
+          //   .map(([key, value]) => value)
+          //   .every((value) => value === false);
 
           cy.get(
             ".read-only-box > cds-inline-notification#readOnlyNotification"
-          ).should(
-            success || scenario.showDuplicatedNotification
-              ? "exist"
-              : "not.exist"
-          );
+          ).should("exist");
 
           cy.get(`.read-only-box > #legalType > .title-group-01 > .label-01`)
             .should("exist")

diff --git a/frontend/src/pages/staffform/BcRegisteredClientInformationWizardStep.vue b/frontend/src/pages/staffform/BcRegisteredClientInformationWizardStep.vue
@@ -390,7 +390,6 @@ onMounted(() => {
       <cds-inline-notification
       id="readOnlyNotification"
       v-shadow="2"
-      v-if="formData.businessInformation.goodStandingInd === 'Y' || showOnError"
       low-contrast="true"
       open="true"
       kind="info"