Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe): Highlight text on Auto Complete options #1285

Closed
wants to merge 8 commits into from

Conversation

mamartinezmejia
Copy link
Collaborator

@mamartinezmejia mamartinezmejia commented Oct 29, 2024


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Contributor

Current changelog

Features

  • fe: Highlight text on Auto Complete options (64cc012)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Collaborator

@fterra-encora fterra-encora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to prevent issues when user enters characters like: ( . / and others.
In some cases they lead to "SyntaxError: Invalid regular expression".
I suggest to install "lodash" and use its escapeRegExp (or if prefered install only that single function with package "lodash.escaperegexp").

@mamartinezmejia mamartinezmejia removed the request for review from paulushcgcj October 30, 2024 13:16
@mamartinezmejia mamartinezmejia marked this pull request as draft October 30, 2024 13:24
Copy link
Contributor

Current changelog

Features

  • fe: Highlight text on Auto Complete options (64cc012)

@mamartinezmejia mamartinezmejia marked this pull request as ready for review October 30, 2024 14:02
Copy link
Contributor

Current changelog

Features

  • fe: Highlight text on Auto Complete options (64cc012)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@mamartinezmejia
Copy link
Collaborator Author

We need to prevent issues when user enters characters like: ( . / and others. In some cases they lead to "SyntaxError: Invalid regular expression". I suggest to install "lodash" and use its escapeRegExp (or if prefered install only that single function with package "lodash.escaperegexp").

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@mamartinezmejia
Copy link
Collaborator Author

We need to prevent issues when user enters characters like: ( . / and others. In some cases they lead to "SyntaxError: Invalid regular expression". I suggest to install "lodash" and use its escapeRegExp (or if prefered install only that single function with package "lodash.escaperegexp").

I did this with a different approach to avoid installing external libraries.

@DerekRoberts DerekRoberts deleted the feat/fe/FSADT1-1565 branch December 3, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants