Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe): adjust search table column widths #1301

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented Nov 6, 2024

Description

Adjusts column widths in a responsive manner and uses a small min-width for the search data-table so it doesn't need the horizontal scroll until the screen goes below 1280px.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)
  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Current changelog

Features

  • adjust search table column widths (8edba8d)

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Current changelog

Features

  • adjust search table column widths (8edba8d)
  • apply width and min-width globally to cds-table (dd97809)

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@mamartinezmejia mamartinezmejia merged commit d743f53 into main Nov 6, 2024
25 of 26 checks passed
@mamartinezmejia mamartinezmejia deleted the feat/search-table-columns-width branch November 6, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants