Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FSADT1-842): full test external application #556

Closed
wants to merge 28 commits into from

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented Aug 10, 2023

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@github-actions github-actions bot added javascript Pull requests that update Javascript code tests test classes changes source source code changes configuration changes related to configuration file frontend labels Aug 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Current changelog

Bug Fixes

  • get the domain to be set in the cookie dynamically (c160d14)
  • redirect to the proper route based on the login type (3e5cc79)
  • stub requests to the backend (e48b979)

@github-actions github-actions bot removed the configuration changes related to configuration file label Aug 14, 2023
@paulushcgcj paulushcgcj temporarily deployed to dev August 14, 2023 16:59 — with GitHub Actions Inactive
@github-actions github-actions bot removed the source source code changes label Aug 14, 2023
@fterra-encora fterra-encora temporarily deployed to dev August 14, 2023 19:09 — with GitHub Actions Inactive
@github-actions github-actions bot added feature and removed feature labels Aug 29, 2023
@paulushcgcj paulushcgcj temporarily deployed to dev August 29, 2023 12:59 — with GitHub Actions Inactive
@paulushcgcj
Copy link
Contributor

Closing for now to free up some resource

@DerekRoberts DerekRoberts deleted the feat/cypress/FSADT1-842 branch November 9, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature frontend javascript Pull requests that update Javascript code tests test classes changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants