Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSADT1-915] Implement tests defined for the Address Group component #590

Merged
merged 2 commits into from
Oct 31, 2023
Merged

[FSADT1-915] Implement tests defined for the Address Group component #590

merged 2 commits into from
Oct 31, 2023

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented Oct 25, 2023 •
edited by github-actions bot
Loading

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@github-actions github-actions bot added javascript Pull requests that update Javascript code tests test classes changes frontend labels Oct 25, 2023
@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

@sonarqubecloud
Copy link

[nr-forest-client-backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@paulushcgcj paulushcgcj temporarily deployed to dev October 31, 2023 00:55 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

[forest-client-frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[nr-forest-client-processor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@paulushcgcj paulushcgcj temporarily deployed to dev October 31, 2023 01:02 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj merged commit 8506bde into main Oct 31, 2023
20 checks passed
@paulushcgcj paulushcgcj deleted the test/fe/FSADT1-915 branch October 31, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamartinezmejia mamartinezmejia mamartinezmejia approved these changes

@paulushcgcj paulushcgcj paulushcgcj approved these changes

Assignees
No one assigned
Labels
frontend javascript Pull requests that update Javascript code tests test classes changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fterra-encora @paulushcgcj @mamartinezmejia