Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FSADT1-817): adding internal pages #591

Merged
merged 23 commits into from
Oct 30, 2023
Merged

feat(FSADT1-817): adding internal pages #591

merged 23 commits into from
Oct 30, 2023

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Oct 25, 2023 •
edited by github-actions bot
Loading

Description

Adding internal submission pages to list submissions and review submissions.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@github-actions github-actions bot added java Pull requests that update Java code javascript Pull requests that update Javascript code github_actions Pull requests that update GitHub Actions code tests test classes changes source source code changes configuration changes related to configuration file backend code related to the java backend application openshift frontend feature labels Oct 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited
Loading

Current changelog

Bug Fixes

Features

  • adding token refresh (9bff6b8)
  • FSADT1-817: adding backend changes (b174c8d)
  • FSADT1-817: adding frontend changes (2f09c3d)
  • FSADT1-817: updating processor code (68c6450)
  • updating url for fam (444acc9)

@github-actions github-actions bot added feature and removed feature labels Oct 25, 2023
@paulushcgcj paulushcgcj temporarily deployed to dev October 25, 2023 19:00 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev October 25, 2023 19:14 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj marked this pull request as ready for review October 25, 2023 20:06
@github-actions github-actions bot added feature and removed feature labels Oct 25, 2023
@paulushcgcj paulushcgcj temporarily deployed to dev October 25, 2023 21:18 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev October 25, 2023 21:24 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev October 27, 2023 22:07 — with GitHub Actions Inactive
@github-actions github-actions bot added feature and removed feature labels Oct 27, 2023
@github-actions github-actions bot added feature and removed feature labels Oct 27, 2023
@paulushcgcj paulushcgcj temporarily deployed to dev October 27, 2023 22:27 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev October 27, 2023 22:34 — with GitHub Actions Inactive
@github-actions github-actions bot added feature and removed feature labels Oct 30, 2023
@paulushcgcj paulushcgcj temporarily deployed to dev October 30, 2023 16:46 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev October 30, 2023 16:53 — with GitHub Actions Inactive
@github-actions github-actions bot added feature and removed feature labels Oct 30, 2023
@paulushcgcj paulushcgcj temporarily deployed to dev October 30, 2023 18:55 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev October 30, 2023 19:02 — with GitHub Actions Inactive
@github-actions github-actions bot added feature and removed feature labels Oct 30, 2023
@sonarqubecloud
Copy link

[nr-forest-client-backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 50 Code Smells

87.4% 87.4% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[nr-forest-client-processor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 80 Code Smells

84.7% 84.7% Coverage
1.4% 1.4% Duplication

@sonarqubecloud
Copy link

[forest-client-frontend] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 6 Security Hotspots
Code Smell A 1 Code Smell

3.4% 3.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@paulushcgcj paulushcgcj temporarily deployed to dev October 30, 2023 19:30 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev October 30, 2023 19:37 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj merged commit a1891db into main Oct 30, 2023
19 of 20 checks passed
@paulushcgcj paulushcgcj deleted the feat/submission branch October 30, 2023 22:20
@github-actions github-actions bot mentioned this pull request Oct 30, 2023
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamartinezmejia mamartinezmejia mamartinezmejia approved these changes

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

Assignees
No one assigned
Labels
backend code related to the java backend application configuration changes related to configuration file feature frontend github_actions Pull requests that update GitHub Actions code java Pull requests that update Java code javascript Pull requests that update Javascript code openshift source source code changes tests test classes changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulushcgcj @mamartinezmejia