Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSADT1-972: Submission (Blue Interface) Client Types #597

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

mamartinezmejia
Copy link
Collaborator

@mamartinezmejia mamartinezmejia commented Nov 8, 2023

  • Worked on FSADT1-972
  • Made the code DRY
  • Made code reviews

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

- Worked on FSADT1-972
- Made the code DRY
- Made code reviews
@github-actions github-actions bot added java Pull requests that update Java code javascript Pull requests that update Javascript code source source code changes configuration changes related to configuration file backend code related to the java backend application frontend labels Nov 8, 2023
- Fixed test
- Code reviews
Copy link

sonarqubecloud bot commented Nov 8, 2023

[nr-forest-client-backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link

sonarqubecloud bot commented Nov 8, 2023

[forest-client-frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link

sonarqubecloud bot commented Nov 8, 2023

[nr-forest-client-processor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mamartinezmejia mamartinezmejia merged commit 2ef22c8 into main Nov 8, 2023
20 checks passed
@mamartinezmejia mamartinezmejia deleted the feat/FSADT1-972 branch November 8, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend code related to the java backend application configuration changes related to configuration file frontend java Pull requests that update Java code javascript Pull requests that update Javascript code source source code changes tests test classes changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants