Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FSADT1-981): fixing contact type association #599

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Nov 9, 2023

Also fixes FSADT1-969

Description

Removing association from client type to BC registry data, as this does not match what we have in our database.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • No new tests are required

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@github-actions github-actions bot added java Pull requests that update Java code tests test classes changes source source code changes backend code related to the java backend application fix labels Nov 9, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Current changelog

Bug Fixes

Copy link

sonarqubecloud bot commented Nov 9, 2023

[nr-forest-client-backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link

sonarqubecloud bot commented Nov 9, 2023

[nr-forest-client-processor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@paulushcgcj paulushcgcj self-assigned this Nov 9, 2023
@paulushcgcj paulushcgcj merged commit c1a3623 into main Nov 9, 2023
19 checks passed
@paulushcgcj paulushcgcj deleted the fix/be/FSADT1-981 branch November 9, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend code related to the java backend application fix java Pull requests that update Java code source source code changes tests test classes changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants