Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FSADT1-1012): updating DoB and data insertion #626

Merged
merged 14 commits into from
Nov 28, 2023
Merged

feat(FSADT1-1012): updating DoB and data insertion #626

merged 14 commits into from
Nov 28, 2023

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Nov 27, 2023 •
edited by github-actions bot
Loading

Description

Updated query insert method to be as close to the method used on the package oracle db. Also, updated the date of birth inserts

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Updating existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@paulushcgcj
feat: updating local copy of oracle db data
a0cc90a
@paulushcgcj
feat(FSADT1-1012): updating DoB insert and data insertion
c5963ea 
- updating data to be inserted as close as the green interface without relying too much on the procedures.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023 •
edited
Loading

Current changelog

Bug Fixes

Features

@paulushcgcj
fix(CVE-2023-34062): fixing security issue with dependency
978f64e 
reactor-netty-http: directory traversal vulnerability
@github-actions github-actions bot added java Pull requests that update Java code backend code related to the java backend application feature and removed feature labels Nov 27, 2023
@paulushcgcj paulushcgcj marked this pull request as ready for review November 27, 2023 20:55
@github-actions github-actions bot added feature and removed feature labels Nov 27, 2023
@github-actions github-actions bot added feature and removed feature labels Nov 27, 2023
@github-actions github-actions bot added feature and removed feature labels Nov 27, 2023
@github-actions github-actions bot removed the feature label Nov 27, 2023
@github-actions github-actions bot added feature and removed feature labels Nov 28, 2023
@github-actions github-actions bot added feature and removed feature labels Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added feature and removed feature labels Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added feature and removed feature labels Nov 28, 2023
@sonarqubecloud SonarQubeCloud
Copy link

[nr-forest-client-backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@sonarqubecloud SonarQubeCloud
Copy link

[nr-forest-client-processor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@paulushcgcj paulushcgcj merged commit 38103be into main Nov 28, 2023
19 checks passed
@paulushcgcj paulushcgcj deleted the feat/FSADT1-1012 branch November 28, 2023 20:01
This was referenced Nov 28, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamartinezmejia mamartinezmejia mamartinezmejia approved these changes

Assignees
No one assigned
Labels
backend code related to the java backend application feature java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulushcgcj @mamartinezmejia