Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating coverage report for frontend #637

Merged
merged 5 commits into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 35 additions & 6 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
if: github.event_name != 'pull_request' || !github.event.pull_request.draft
runs-on: ubuntu-22.04
steps:
- uses: bcgov-nr/action-test-and-analyse-java@v0.2.0
- uses: bcgov-nr/action-test-and-analyse-java@v1.0.0
name: Backend Coverage
with:
commands: |
Expand All @@ -39,8 +39,10 @@ jobs:
-Dsonar.coverage.jacoco.xmlReportPaths=target/coverage-reports/merged-test-report/jacoco.xml
-Dsonar.java.checkstyle.reportPaths=target/checkstyle-result.xml
-Dsonar.coverage.exclusions=**/configuration/**,**/exception/**,**/dto/**,**/entity/**,**/models/**,**/repository/**,**/*$*Builder*,**/BootApplication*
sonar_project_token: ${{ secrets.SONAR_TOKEN_BACKEND }}
- uses: bcgov-nr/[email protected]
sonar_token: ${{ secrets.SONAR_TOKEN_BACKEND }}
triggers: ('backend/')

- uses: bcgov-nr/[email protected]
name: Legacy Coverage
with:
commands: |
Expand All @@ -55,8 +57,10 @@ jobs:
-Dsonar.coverage.jacoco.xmlReportPaths=target/coverage-reports/merged-test-report/jacoco.xml
-Dsonar.java.checkstyle.reportPaths=target/checkstyle-result.xml
-Dsonar.coverage.exclusions=**/configuration/**,**/exception/**,**/dto/**,**/entity/**,**/repository/**,**/*$*Builder*,**/LegacyApplication***/ApplicationConstants*
sonar_project_token: ${{ secrets.SONAR_TOKEN_LEGACY }}
- uses: bcgov-nr/[email protected]
sonar_token: ${{ secrets.SONAR_TOKEN_LEGACY }}
triggers: ('legacy/')

- uses: bcgov-nr/[email protected]
name: Processor Coverage
with:
commands: |
Expand All @@ -71,7 +75,8 @@ jobs:
-Dsonar.coverage.jacoco.xmlReportPaths=target/coverage-reports/merged-test-report/jacoco.xml
-Dsonar.java.checkstyle.reportPaths=target/checkstyle-result.xml
-Dsonar.coverage.exclusions=**/configuration/**,**/dto/**,**/exception/**,**/entity/**,**/repository/**,**/*$*Builder*,**/ProcessApplication***/ApplicationConstant*
sonar_project_token: ${{ secrets.SONAR_TOKEN_PROCESSOR }}
sonar_token: ${{ secrets.SONAR_TOKEN_PROCESSOR }}
triggers: ('processor/')

- name: Archive CycloneDX
continue-on-error: true
Expand Down Expand Up @@ -136,6 +141,30 @@ jobs:
-Dsonar.projectKey=forest-client-frontend
sonar_token: ${{ secrets.SONAR_TOKEN_FRONTEND }}
triggers: ('frontend/')

- name: Frontend Unit Coverage
uses: romeovs/[email protected]
with:
title: Frontend unit Test Coverage
delete-old-comments: true
github-token: ${{ github.token }}
lcov-file: ./frontend/reports/unit/lcov.info

- name: Frontend Component Coverage
uses: romeovs/[email protected]
with:
title: Frontend component Test Coverage
delete-old-comments: true
github-token: ${{ github.token }}
lcov-file: ./frontend/reports/component/lcov.info

- name: Frontend E2E Coverage
uses: romeovs/[email protected]
with:
title: Frontend e2e Test Coverage
delete-old-comments: true
github-token: ${{ github.token }}
lcov-file: ./frontend/reports/e2e/lcov.info

trivy:
name: Repository Report
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,6 @@ describe("<AddressGroupComponent />", () => {

cy.wait("@getProvinces");

/*cy.get("#postalCode_0")
.should("be.visible")
.shadow()
.find("label")
.and("include.text", "Postal code");*/

// Wait for the option's inner, standard HTML element to exist before clicking the combo-box
cy.get("#country_0")
.find('cds-combo-box-item[data-id="CA"]')
Expand Down Expand Up @@ -230,11 +224,6 @@ describe("<AddressGroupComponent />", () => {
.click()
.and("have.value", "Illinois");

/*cy.get("#postalCode_0")
.should("be.visible")
.shadow()
.find("label")
.and("include.text", "Zip code");*/
});

const streetAddressMatchingScenarios = [
Expand Down
Loading