[FSADT1-999] Add birth date to frontend #643

fterra-encora · 2023-11-29T22:15:59Z

Description

Adds a date input component as specified;
Adds validation rules;
Adds the birth date field to the frontend.

Fixes # (issue)

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Checklist

I have read the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Specially for date of birth.

Replaces the types of event emmited and used to determine when to enable the next button.

github-actions · 2023-11-29T22:16:24Z

Current changelog

Bug Fixes

adjust validations and events (fdf581a)
always revalidate day (173f3e2)
disable the next button properly (f4c2e94)
issue after returning to the step containing the date (8b74cba)
make complexity of regex linear (2822592)
prevent highlighting all parts on error (039d6fb)
revalidate everything on revalidate-bus (0879deb)

Features

add a date input component (ab5eed9)
add birthdate label (6404304)
add business validations (2b67458)
add condition for displaying the birthdate (062f910)
add the date of birth to the form (a87655a)
apply text mask (c084b59)
auto-move to next date part (35cdcd6)
perform conditional validation (ccbf063)
replace some messages (3300c25)

github-actions · 2023-11-29T22:16:31Z

Overall Project	NaN% `NaN%`	🍏

There is no coverage information present for the Files changed

github-actions · 2023-11-29T22:34:57Z

Overall Project	NaN% `NaN%`	🍏

There is no coverage information present for the Files changed

github-actions · 2023-11-30T20:03:47Z

Overall Project	NaN% `NaN%`	🍏

There is no coverage information present for the Files changed

Fixes the security risk pointed by sonarcloud.

Moves from `DateValidator` to props for part-specific business validations.

github-actions · 2023-11-30T21:29:26Z

Overall Project	NaN% `NaN%`	🍏

There is no coverage information present for the Files changed

github-actions · 2023-11-30T21:39:18Z

Overall Project	NaN% `NaN%`	🍏

There is no coverage information present for the Files changed

sonarqubecloud · 2023-11-30T21:43:30Z

[forest-client-frontend] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

83.8% Coverage
0.0% Duplication

github-actions · 2023-11-30T21:43:35Z

Frontend unit Test Coverage

Coverage after merging feat/fe/FSADT1-999 into main will be

47.27%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	48.39%	50%	0%	68.42%	108, 36, 39–40, 44, 52–53, 62
directivesMap.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	85%	60%	83.33%	95.83%	33–35, 50, 55
MainHeaderComponent.vue	79.69%	76.56%	58.33%	88.46%	100, 107, 111, 122, 124, 134, 136, 147, 173, 176, 185, 201, 217, 217, 217, 230, 249, 41, 50–51, 55
UserProfileComponent.vue	80%	33.33%	100%	85.71%	17, 17, 19, 23
src/components/forms
AutoCompleteInputComponent.vue	75.38%	58.54%	80.95%	83.82%	110–111, 127, 132–133, 201, 46, 59, 61, 61, 61, 61, 61–63, 65, 65, 65–67, 77, 80, 80, 80, 80, 80, 82, 84
DropdownInputComponent.vue	89.11%	83.87%	83.33%	94.23%	111, 136, 152, 67, 81, 81, 81–82
MultiselectInputComponent.vue	91.49%	87.50%	85.71%	95.92%	100, 109, 122, 80, 89
RadioInputComponent.vue	88.46%	91.67%	75%	92.86%	38, 43, 82
ReadOnlyComponent.vue	66.67%	100%	100%	66.67%	2
TextInputComponent.vue	86.49%	77.27%	84.62%	92.31%	122–123, 130, 55, 84, 89–90, 98
src/components/forms/DateInputComponent
DateInputPart.vue	8.70%	0%	0%	15.38%	16, 21, 23, 25, 27, 31, 37, 39, 46, 46, 50, 50, 57, 57, 57–58, 58, 58, 8
common.ts	100%	100%	100%	100%
index.vue	2.60%	0%	0%	4.70%	102, 102, 102–104, 104, 104, 110, 110, 110, 110–111, 113, 116, 116, 116, 118, 124, 124, 124, 124, 124–125, 128, 131–133, 136, 142, 144–145, 145, 145, 148, 150–152, 154, 156–157, 157, 157, 157, 159–160, 160, 160, 160, 163, 165, 167–170, 173–178, 178, 178, 178, 178–181, 181, 181–182, 185, 189–190, 194–197, 199, 199, 199–200, 203–204, 208–209, 209, 209, 211, 211, 211–212, 214, 214, 214–215, 218–219, 221, 224, 230, 236, 242, 25, 265, 265, 265–266, 268, 271, 271, 271, 271, 271–272, 274, 285, 285, 285–286, 286, 286–287, 287, 287, 289, 289, 289–290, 293–296, 298, 300, 300, 300–301, 301, 301, 305, 308, 308, 308–309, 311, 314–316, 318–322, 325–326, 329, 329, 329–331, 333–334, 336–337, 339, 339, 339–340, 345, 350, 352, 358, 360–366, 366, 366–368, 368, 368–371, 371, 371–372, 378–380, 382, 388, 428, 428–429, 429, 429, 438, 438–439, 439, 439, 448, 448–449, 449, 449, 456, 456, 462, 462, 468, 468, 50, 72, 72, 72, 74, 76, 82, 88, 97, 97, 97–99
src/components/grouping
AddressGroupComponent.vue	1.22%	0%	0%	2.73%	104–105, 107, 107, 107, 111–112, 114–115, 115, 115, 115, 117, 124, 131, 140–141, 141, 141, 141, 143, 145, 147, 151, 153–154, 154, 154–155, 155, 155, 155, 157, 159, 161, 164, 168–169, 169, 169, 169, 171, 173, 175, 179–180, 180, 180, 183, 185–186, 186–187, 187, 189, 19, 192, 194–196, 196, 196, 196, 196–198, 206, 208–209, 212, 214, 219–220, 220, 220–225, 225, 225–227, 230, 234–235, 235, 235–236, 247, 247, 247, 254, 254, 254–255, 255, 255–256, 256, 268, 268, 268, 270, 270, 270, 274, 274, 274, 28, 285, 285, 285–286, 286, 292, 292, 292, 294, 294, 294–295, 295, 295, 297, 297, 304, 304, 304, 312, 312, 312–313, 313, 313, 317, 317, 317, 333, 333, 333–334, 334, 334, 34, 345, 345, 345, 348, 348,

github-actions · 2023-11-30T21:43:37Z

Frontend component Test Coverage

Coverage after merging feat/fe/FSADT1-999 into main will be

91.86%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	100%	100%	100%	100%
CoreConstants.ts	100%	100%	100%	100%
directivesMap.ts	100%	100%	100%	100%
main.ts	100%	100%	100%	100%
routes.ts	100%	100%	100%	100%
shims-vue.d.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	96.97%	80%	100%	100%	33
MainHeaderComponent.vue	100%	100%	100%	100%
UserProfileComponent.vue	100%	100%	100%	100%
src/components/forms
AutoCompleteInputComponent.vue	93.04%	94.12%	85%	95.08%	40, 45, 67, 79, 82
DropdownInputComponent.vue	89.02%	87.50%	82.35%	92.68%	111, 135, 152, 81, 81–82
MultiselectInputComponent.vue	89.61%	84.21%	85%	94.74%	108, 122, 47, 88, 99
RadioInputComponent.vue	100%	100%	100%	100%
ReadOnlyComponent.vue	100%	100%	100%	100%
TextInputComponent.vue	90%	86.67%	83.33%	93.94%	123, 138, 54, 98
src/components/forms/DateInputComponent
DateInputPart.vue	100%	100%	100%	100%
common.ts	100%	100%	100%	100%
index.vue	100%	100%	100%	100%
src/components/grouping
AddressGroupComponent.vue	89.38%	90.36%	90.48%	88.12%	115, 131, 141, 147, 154–155, 155, 155, 155, 157, 159, 161, 169, 175, 208–209, 225, 274, 317, 354
ContactGroupComponent.vue	91.06%	95.56%	90%	87.50%	100, 136, 208, 215, 84, 91, 99, 99
ErrorNotificationGroupingComponent.vue	100%	100%	100%	100%
src/composables
useFetch.ts	100%	100%	100%	100%
useFocus.ts	100%	100%	100%	100%
useScreenSize.ts	100%	100%	100%	100%
useSvg.ts	100%	100%	100%	100%
src/dto
ApplyClientNumberDto.ts	100%	100%	100%	100%
CommonTypesDto.ts	100%	100%	100%	100%
src/helpers
CustomDirectives.ts	100%	100%	100%	100%
DataConversors.ts	100%	100%	100%	100%
ForestClientUserSession.ts	100%	100%	100%	100%
src/helpers/validators
BCeIDFormValidations.ts	100%	100%	100%	100%
GlobalValidators.ts	100%	100%	100%	100%
SubmissionValidators.ts	100%	100%	100%	100%
src/pages
ErrorPage.vue	100%	100%	100%	100%
FormBCSCPage.vue	100%	100%	100%	100%
FormBCeIDPage.vue	100%	100%	100%	100%
FormSubmittedPage.vue	100%	100%	100%	100%
LandingPage.vue	100%	100%	100%	100%
NotFoundPage.vue	100%	100%	100%	100%
SubmissionListPage.vue	100%	100%	100%	100%
SubmissionReviewPage.vue	100%	100%	100%	100%
UserLoadingPage.vue	100%	100%	100%	100%
src/pages/bceidform
AddressWizardStep.vue	100%	100%	100%	100%
BusinessInformationWizardStep.vue	100%	100%	100%	100%
ContactWizardStep.vue	100%	100%	100%	100%
ReviewWizardStep.vue	100%	100%	100%	100%
src/services
ForestClientService.ts	100%	100%	100%	100%

github-actions · 2023-11-30T21:43:40Z

Frontend e2e Test Coverage

Coverage after merging feat/fe/FSADT1-999 into main will be

57.46%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	45.83%	100%	0%	66.67%	39–40, 44, 52–53
CoreConstants.ts	100%	100%	100%	100%
directivesMap.ts	100%	100%	100%	100%
main.ts	100%	100%	100%	100%
routes.ts	100%	100%	100%	100%
shims-vue.d.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	96.97%	80%	100%	100%	33
MainHeaderComponent.vue	38%	40%	8.33%	44.19%	118, 125, 133, 148, 150, 173, 173–174, 174–175, 175, 178, 178, 185, 185, 185, 196, 199, 216, 216, 216, 229, 248, 41, 41–42, 50, 50, 50, 50–51, 53–55, 55–56, 56, 56–57, 59, 66–67, 70–72, 81, 87, 87, 87–88, 90
UserProfileComponent.vue	0%	0%	0%	0%	11, 17, 17, 17, 17, 19, 21, 23, 4
src/components/forms
AutoCompleteInputComponent.vue	93.91%	97.06%	85%	95.08%	45, 67, 79, 82
DropdownInputComponent.vue	89.02%	87.50%	82.35%	92.68%	111, 135, 152, 81, 81–82
MultiselectInputComponent.vue	89.61%	84.21%	85%	94.74%	108, 122, 47, 88, 99
RadioInputComponent.vue	88.10%	80%	80%	95.45%	37, 48, 82
ReadOnlyComponent.vue	0%	100%	100%	0%	2
TextInputComponent.vue	90%	86.67%	83.33%	93.94%	123, 138, 54, 98
src/components/forms/DateInputComponent
DateInputPart.vue	90%	71.43%	100%	100%	45, 63
common.ts	100%	100%	100%	100%
index.vue	83.70%	77.27%	92.31%	85.19%	104, 113, 116, 118, 132, 144, 199, 214, 221, 265–266, 271–272, 285–287, 289–290, 300, 300, 305, 319–322, 329–331, 333–334, 336–337, 339, 339–340
src/components/grouping
AddressGroupComponent.vue	89.38%	90.36%	90.48%	88.12%	115, 131, 141, 147, 154–155, 155, 155, 155, 157, 159, 161, 169, 175, 208–209, 225, 274, 317, 354
ContactGroupComponent.vue	91.06%	95.56%	90%	87.50%	100, 136, 208, 215, 84, 91, 99, 99
ErrorNotificationGroupingComponent.vue	35.59%	8.70%	57.14%	51.72%	111, 117, 117, 117, 122, 135, 135, 139, 151, 175, 175, 175, 178, 178, 30–31, 31, 34, 58, 58, 58, 63, 63–64, 64, 64, 66–67, 67, 69, 73–74, 74, 76, 90
src/composables
useFetch.ts	100%	100%	100%	100%
useFocus.ts	100%	100%	100%	100%
useScreenSize.ts	100%	100%	100%	100%
useSvg.ts	100%	100%	100%	100%
src/dto
ApplyClientNumberDto.ts	100%	100%	100%	100%
CommonTypesDto.ts	100%	100%	100%	100%
src/helpers
CustomDirectives.ts	100%	100%	100%	100%
DataConversors.ts	100%	100%	100%	100%
ForestClientUserSession.ts	100%	100%	100%	100%
src/helpers/validators
BCeIDFormValidations.ts	100%	100%	100%	100%
GlobalValidators.ts	100%	100%	100%	100%
SubmissionValidators.ts	100%	100%	100%	100%
src/pages
ErrorPage.vue	0%	100%	100%	0%	11–12
FormBCSCPage.vue	0%	0%	0%	0%	114–116, 122, 122, 150, 150, 150, 186, 186, 186, 239–241, 243, 246, 246–247, 247–248, 248, 252, 254, 260, 260, 260, 262, 264–267, 270, 276, 276, 288, 290, 295–296, 299–300, 311, 315, 317–319, 324–326, 328, 331–332, 332–334, 337, 337–339, 341, 344, 346–350, 359, 361–362, 362–363, 363, 363, 365–367, 37, 37, 37, 370, 374, 378–379, 379–380, 384–385, 385, 385, 391, 396–397, 399, 401–402, 402, 402, 407, 416, 420, 422, 443, 445, 449, 453, 455–457, 457–458, 462, 462–463, 473, 475, 479, 484, 487, 487–488, 488–489, 489, 494–496, 498, 498–501, 505–506, 506–507, 511–512, 512, 512, 515, 521, 84, 84, 84, 91, 91, 91–92, 92, 92
FormBCeIDPage.vue	52.55%	47.06%	36.67%	61.22%	109–111, 118, 118–119, 124, 124, 124, 127, 133, 239–240, 250, 260–261, 261, 261, 261, 261, 261–264, 279, 279–284, 298, 298–299, 303, 303–304, 304–305, 305, 311, 317–318, 320, 320–322, 327–328, 335, 340–344, 354, 354, 356–358, 430, 460, 460, 460, 477, 477, 477, 525, 549, 67–69, 95, 98
FormSubmittedPage.vue	0%	0%	0%	0%	11–12, 15, 31, 31, 31, 33, 9
LandingPage.vue	66.67%	60%	100%	75%	18, 18–19
SubmissionListPage.vue	0%	0%	0%	0%	103–105, 137, 23, 26–28, 31–34, 37–38, 41–42, 42–43, 46, 46, 46, 49–51, 54–55, 55, 55, 55, 55, 57, 59, 61, 63, 67–69, 69, 72–73, 75–76, 79–82, 82, 82–83, 85, 88, 91–92, 92–93, 96–97, 97, 97, 97–99
SubmissionReviewPage.vue	0%	0%	0%	0%	102, 104–106, 114, 114–115, 115, 121–122, 122–125,

fterra-encora added 17 commits November 27, 2023 09:14

feat: add a date input component

ab5eed9

Specially for date of birth.

refactor: extract date part component

5da037b

fix: always revalidate day

173f3e2

feat: add the date of birth to the form

a87655a

refactor: reuse enum DatePart

c645a9b

feat: add condition for displaying the birthdate

062f910

feat: add birthdate label

6404304

style: replace single-quote with double-quote

a109cf9

fix: disable the next button properly

f4c2e94

Replaces the types of event emmited and used to determine when to enable the next button.

fix: adjust validations and events

fdf581a

fix: issue after returning to the step containing the date

8b74cba

feat: add business validations

2b67458

feat: apply text mask

c084b59

feat: auto-move to next date part

35cdcd6

feat: perform conditional validation

ccbf063

fix: revalidate everything on revalidate-bus

0879deb

Merge branch 'main' into feat/fe/FSADT1-999

b95d132

fterra-encora requested review from paulushcgcj and mamartinezmejia as code owners November 29, 2023 22:15

github-actions bot added javascript Pull requests that update Javascript code source source code changes frontend labels Nov 29, 2023

fterra-encora temporarily deployed to dev November 29, 2023 22:19 — with GitHub Actions Inactive

fterra-encora temporarily deployed to dev November 29, 2023 22:27 — with GitHub Actions Inactive

test: fill the birthdate field

24bbb5f

github-actions bot added the tests test classes changes label Nov 29, 2023

fterra-encora temporarily deployed to dev November 29, 2023 22:37 — with GitHub Actions Inactive

fterra-encora temporarily deployed to dev November 29, 2023 22:44 — with GitHub Actions Inactive

fterra-encora marked this pull request as draft November 30, 2023 18:56

paulushcgcj approved these changes Nov 30, 2023

View reviewed changes

fterra-encora added 2 commits November 30, 2023 16:38

feat: replace some messages

3300c25

fix: prevent highlighting all parts on error

039d6fb

fterra-encora had a problem deploying to dev November 30, 2023 20:00 — with GitHub Actions Error

docs: improve code comment

cd07766

fterra-encora marked this pull request as ready for review November 30, 2023 20:03

fterra-encora temporarily deployed to dev November 30, 2023 20:06 — with GitHub Actions Inactive

fterra-encora temporarily deployed to dev November 30, 2023 20:14 — with GitHub Actions Inactive

paulushcgcj approved these changes Nov 30, 2023

View reviewed changes

fterra-encora added 2 commits November 30, 2023 18:09

fix: make complexity of regex linear

2822592

Fixes the security risk pointed by sonarcloud.

refactor: move date part validations to props

65b482b

Moves from `DateValidator` to props for part-specific business validations.

fterra-encora had a problem deploying to dev November 30, 2023 21:32 — with GitHub Actions Error

Merge branch 'main' into feat/fe/FSADT1-999

357c6d0

fterra-encora temporarily deployed to dev November 30, 2023 21:40 — with GitHub Actions Inactive

fterra-encora temporarily deployed to dev November 30, 2023 21:48 — with GitHub Actions Inactive

fterra-encora merged commit 72f549f into main Nov 30, 2023
17 checks passed

fterra-encora deleted the feat/fe/FSADT1-999 branch November 30, 2023 21:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FSADT1-999] Add birth date to frontend #643

[FSADT1-999] Add birth date to frontend #643

fterra-encora commented Nov 29, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Nov 29, 2023 •

edited

Loading

github-actions bot commented Nov 29, 2023

github-actions bot commented Nov 29, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

sonarqubecloud bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

[FSADT1-999] Add birth date to frontend #643

[FSADT1-999] Add birth date to frontend #643

Conversation

fterra-encora commented Nov 29, 2023 • edited by github-actions bot Loading

Description

Type of change

How Has This Been Tested?

Checklist

Further comments

github-actions bot commented Nov 29, 2023 • edited Loading

Current changelog

Bug Fixes

Features

github-actions bot commented Nov 29, 2023

github-actions bot commented Nov 29, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

sonarqubecloud bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

Frontend unit Test Coverage

github-actions bot commented Nov 30, 2023

Frontend component Test Coverage

github-actions bot commented Nov 30, 2023

Frontend e2e Test Coverage

fterra-encora commented Nov 29, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Nov 29, 2023 •

edited

Loading